Zhiqiang ZHOU

Results 341 comments of Zhiqiang ZHOU

hi @alvaroaleman , could we push the progress of this PR

what do you think? If you are not satisfied with this design, I am very happy to make it better. :) /cc @FillZpp @vincepri @alvaroaleman

Ohh, I missed that method. That would help a lot. We do not require the first step in my original design. ❤️ But the user still needs to implement `Handler`...

I think it's better also support waning on high-level API `Validator`/`CustomValidator` based on the provided low-level API `Response.WithWarnings`. :)

`ErrorCode`, `Reason` could be carried with `apierrors.APIStatus`: https://github.com/kubernetes-sigs/controller-runtime/blob/b826f390522092f54fbea9ff18a97ddde4a828b5/pkg/webhook/admission/validator.go#L71-L78 `Warning` is not considered right now, so I think maybe we could use a similar way. :) One different thing is a...

Hi @invidian , I create a PR for resolve this issue, PTAL ❤️

related PR: https://github.com/kubernetes-sigs/controller-runtime/pull/1211

> Is that all we have to do? No. IMO, including the webhook server, there are also other components that need integration with tracing, like - Controller and Reconciler -...

For almost all the controllers/operators based on controller-runtime, the Reconciler is the most important part which contains their core business logic. I think there is no reason to ignore the...