react-router-component icon indicating copy to clipboard operation
react-router-component copied to clipboard

Published 20 hours ago • verified publisher icon STRML

wip(cwrp): deprecate crwp.

Open STRML opened this issue 5 years ago • 0 comments

Server-side tests are working, but browser-side tests are really broken.

Main issue is that setting props on a router should fire an onNavigate() action, but it doesn't since there is no longer state and no code runs on a prop change.

We may have to move this callback to render() somehow, or rethink how we handle prop changes completely.

We also may have to remove the user-supplied setRoutingState.

Relates to #207

STRML avatar Dec 30 '19 16:12 STRML