stm32h7xx_hal_driver icon indicating copy to clipboard operation
stm32h7xx_hal_driver copied to clipboard

PTP coarse/fine update mode selection dropped from HAL_ETH_PTP_SetConfig() by mistake?

Open KarstenHohmeier opened this issue 1 year ago • 2 comments

The recent HAL release dropped the code for the coarse/fine update mode selection below from HAL_ETH_PTP_SetConfig().

https://github.com/STMicroelectronics/stm32h7xx_hal_driver/blob/7a9b4eff63551204638c15f6b9faa0e1cfea219e/Src/stm32h7xx_hal_eth.c#L1537-L1541

ETH_MACTSCR_TSCFUPDT may have been confused with ETH_MACTSCR_TSUPDT (a normal timestamp update which happens right after) and thus be deleted. With this code missing ETH_PTP_ConfigTypeDef.TimestampUpdateMode will no longer be applied when configuring PTP.

KarstenHohmeier avatar Aug 28 '24 13:08 KarstenHohmeier