STM32CubeWL icon indicating copy to clipboard operation
STM32CubeWL copied to clipboard

[SYSTIME] Prevents SysTimeToMs computations that may cause miscalculations when calendarTime is too large

Open wdfk-prog opened this issue 1 year ago • 1 comments

wdfk-prog avatar May 10 '24 08:05 wdfk-prog

ST Internal Reference: 181479

RJMSTM avatar May 15 '24 14:05 RJMSTM

Hello @wdfk-prog,

Thank you for your contribution. You have proposed three changes, detailed as follows:

  1. "[LoRaMac ProcessRadioTxDone] Optimize code reading and execution conditions"
  • We cannot accept this change because we aim to implement a better solution, the condition if(MacCtx.NodeAckRequested == false) is evaluated for every LORAMAC_VERSION, and we plan to move this check elsewhere.
  1. "[LoRaMac] Add SendInfo function and GetMaxPayloadLength function for use by the outer layer"
  • We cannot accept this change as it is considered a custom solution rather than a general one.
  1. "[SYSTIME] Prevents SysTimeToMs computations that may cause miscalculations when calendarTime is too large"
  • Could you provide more details? Specifically, we need clarification on the module operation with 4194304000.

Regards,

RJMSTM avatar Feb 12 '25 14:02 RJMSTM