STM32CubeG4 icon indicating copy to clipboard operation
STM32CubeG4 copied to clipboard

__PKHBT and __PKHTB are STILL wrong

Open etheory opened this issue 1 year ago • 2 comments

As you can see here: https://github.com/STMicroelectronics/STM32CubeG4/blob/29e23e9f45f0a495eafbfb341d98d65ca967e6ff/Drivers/CMSIS/Include/cmsis_gcc.h#L2129-L2152

The version in this repository is STILL incorrect, and should be fixed please. Here is the CMSIS version: https://github.com/ARM-software/CMSIS_5/blob/a75f01746df18bb5b929dfb8dc6c9407fac3a0f3/CMSIS/Core/Include/cmsis_gcc.h#L2183-L2200

I reported this months ago and you closed my PR since you said it didn't match the CMSIS version, but clearly it does: https://github.com/STMicroelectronics/STM32CubeG4/pull/39

Here is the commit change where they changed this: https://github.com/ARM-software/CMSIS_5/commit/8a1fd91319106663f74ca03353a26301f5512fca

etheory avatar Mar 27 '24 04:03 etheory

Hello @etheory,

The latest version of CMSIS available on the STM32CubeG4 repository is 5.6.0, which does not include the most recent commits indicating that this change has already been made."

image

I will forward this matter to the development team to determine whether we will integrate the latest version of CMSIS.

Thank you for your contribution.

Regards,

RJMSTM avatar Mar 29 '24 11:03 RJMSTM

Hello @etheory,

The latest version of CMSIS available on the STM32CubeG4 repository is 5.6.0, which does not include the most recent commits indicating that this change has already been made."

image

I will forward this matter to the development team to determine whether we will integrate the latest version of CMSIS.

Thank you for your contribution.

Regards,

@RJMSTM CMSIS-5.6.0 is 5 years old. The commit that resolved this issue is 2 years old. That's pretty old. It definitely feels like your dependencies should be more up to date than that. Thanks.

etheory avatar Mar 29 '24 12:03 etheory