ScratchTools icon indicating copy to clipboard operation
ScratchTools copied to clipboard

Many discrepancies with Revert to Blue

Open MohsinTeddy opened this issue 1 year ago • 4 comments

Describe the bug. What is going wrong?

A bunch of Issues with Revert to Blue

  1. Profile header color is different to the main page header color and 404 oage image image
  2. Purple Text (Scratch Addons Dark mode) image
  3. Purple Profile Dropdown menu (Scratch Addons Dark mode) image
  4. Purple Griffpatch 😭 image
  5. Purple Buttons (Scratch Addons Dark Mode) image
  6. Purple Flag Highlight image
  7. Purple Sprite Highlight image
  8. Purple Comment Highlight image
  9. Purple Project Icon image
  10. Purple My Stuff Page image

What is causing the bug?

idk, not coded ig

Anything else?

No response

MohsinTeddy avatar Jul 06 '23 09:07 MohsinTeddy

Describe the bug. What is going wrong?

A bunch of Issues with Revert to Blue

  1. Profile header color is different to the main page header color and 404 oage image image
  2. Purple Text (Scratch Addons Dark mode) image
  3. Purple Profile Dropdown menu (Scratch Addons Dark mode) image
  4. Purple Griffpatch 😭 image
  5. Purple Buttons (Scratch Addons Dark Mode) image
  6. Purple Flag Highlight image
  7. Purple Sprite Highlight image
  8. Purple Comment Highlight image
  9. Purple Project Icon image
  10. Purple My Stuff Page image

What is causing the bug?

idk, not coded ig

Anything else?

No response

Firstly, to address the first point, profile pages and 404 pages are 2.0 pages and the colors by default are darker than normal scratch blue and that's why we recreated it like that. Also, to address the second point, by default the scratch addons dark mode was recently updated making all links, highlight colors and more to be purple. That's why the front page links like griffpatch's username are purple. Also, I want to point out that griffpatch's icon being purple is not a bug from ScratchTools side, in fact it's not a bug from SA either. He changed his icon a few days ago to reflect the new scratch colors. The dropdown being that color is also a cause of the scratch addons dark mode addon. The purple buttons in the explore page - same thing, it's because of that addon. Purple sprite highlight is actually a bug, so thanks for that! Comment highlights too! I fixed the purple project icon color in a recent pr and it should be updated soon. The purple my stuff banner only exists because of SA and it's a result of the 2.0 to 3.0 addon. I can make a seperate pr addressing that concern. Thanks for the bug report :)

MaterArc avatar Jul 06 '23 12:07 MaterArc

I wish it was compatible with SA's website color mode since I want certain things that SA doesn't add, but it causes other colors to be messed up and for the 3.0 pages to have the 3.0 colors instead of 2.0 ones, though that likely won't be added until later if at all. Also, usernames in topics and closed topic links appear blue for me with this on.

medlans avatar Jul 11 '23 00:07 medlans

I wish it was compatible with SA's website color mode since I want certain things that SA doesn't add, but it causes other colors to be messed up and for the 3.0 pages to have the 3.0 colors instead of 2.0 ones, though that likely won't be added until later if at all. Also, usernames in topics and closed topic links appear blue for me with this on.

I'll try to add compatibility to this feature in the future, right now though, I want to make sure that the core aspects of the feature work and are for the most part bug-free.

MaterArc avatar Jul 11 '23 12:07 MaterArc

Thanks for bringing up the forum topics thing, that should be an easy fix

MaterArc avatar Jul 11 '23 12:07 MaterArc