octotiger icon indicating copy to clipboard operation
octotiger copied to clipboard

Published 20 hours ago • verified publisher icon STEllAR-GROUP

Move run_as_os_thread from hpx::threads to hpx::

Open G-071 opened this issue 1 year ago • 2 comments

run_as_os_thread was moved to a different namespace within HPX. This caused some deprecation warnings (and in the case of hipcc actually some compilation errors). This PR should fix that by using the updated namespace.

G-071 avatar Jan 13 '24 18:01 G-071

Unfortunately, changing the namespace make Octo-Tiger incompatible with HPX 1.9.1 as it is still using the old one (hence the failing tests). I think we should postpone this PR at least until the next stable HPX release!

I will attempt to fix the issue with the hipcc compilation on the HPX side though so that we can still use HPX master on AMD devices if required!

G-071 avatar Jan 13 '24 22:01 G-071

@G-071 Since HPX 1.10 is releases could we switch to this version and merge the pull request?

diehlpk avatar Jul 10 '24 19:07 diehlpk