hpx icon indicating copy to clipboard operation
hpx copied to clipboard

Fix HPX_WITH_FETCH_BOOST

Open Pansysk75 opened this issue 1 year ago • 3 comments

Fixes following issues when HPX_WITH_FETCH_BOOST=ON:

  • Boost being re-fetched on projects that would depend on HPX.
  • Boost not compiling necessary libraries when a non header-only instance of Boost was needed

Now when HPX_WITH_FETCH_BOOST=ON Boost will be installed alongside HPX.

To fix:

  • [ ] Duplicated code for figuring out which Boost libraries are needed
  • [ ] Make hpx_boost_root-install.cmake contain relative path instead of absolute(?)

Pansysk75 avatar Jun 17 '24 21:06 Pansysk75

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.10% :white_check_mark:
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d08354defb0a5c37bf5ad5da77191f10db9c3067) 222123 188895 85.04%
Head commit (0e1fe2d89e76340909852d261f0b9125a826da41) 191114 (-31009) 162717 (-26178) 85.14% (+0.10%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6511) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


:rocket: Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

codacy-production[bot] avatar Jun 18 '24 01:06 codacy-production[bot]

/retest lsu

srinivasyadav18 avatar Sep 18 '24 23:09 srinivasyadav18

/retest

srinivasyadav18 avatar Sep 19 '24 00:09 srinivasyadav18

@Pansysk75 could you rebase this onto master to resolve the conflicts, please?

hkaiser avatar Nov 02 '24 14:11 hkaiser

@Pansysk75 could you rebase this onto master to resolve the conflicts, please?

This PR should be discarded in favor of #6510.

Pansysk75 avatar Nov 02 '24 16:11 Pansysk75