hpx icon indicating copy to clipboard operation
hpx copied to clipboard

Always return outermost thread id

Open Pansysk75 opened this issue 1 year ago • 9 comments

// Re-opening of PR #6413 authored by @hkaiser

-flyby: deprecate get_outer_self_id -flyby: ignoring locks during termination detection

Pansysk75 avatar Mar 28 '24 21:03 Pansysk75

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: -0.66% :white_check_mark: 91.29%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b60bcf235d509e14a6979b3977b1def05d41d9c1) 243597 208937 85.77%
Head commit (0deeb72b86b42aadd13631157a3c4f05ebfba503) 193827 (-49770) 164963 (-43974) 85.11% (-0.66%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6465) 241 220 91.29%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

codacy-production[bot] avatar Mar 28 '24 23:03 codacy-production[bot]

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)-(=)

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-04-28T17:13:48+00:00
HPX Commitd27ac2efb17ed7a61d0417a1926ba8991f4f477f5e4df47e9197b21851c84965f90c95d913a741fa
Datetime2024-03-18T09:18:04.949759-05:002024-04-28T18:18:24.491797-05:00
Envfile
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch(=)

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-04-28T17:13:48+00:00
HPX Commitd27ac2efb17ed7a61d0417a1926ba8991f4f477f5e4df47e9197b21851c84965f90c95d913a741fa
Datetime2024-03-18T09:19:53.062988-05:002024-04-28T18:20:12.047427-05:00
Envfile
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add=(=)=
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy=(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-04-28T17:13:48+00:00
HPX Commitd27ac2efb17ed7a61d0417a1926ba8991f4f477f5e4df47e9197b21851c84965f90c95d913a741fa
Datetime2024-03-18T09:20:13.002391-05:002024-04-28T18:20:28.690059-05:00
Envfile
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

StellarBot avatar Apr 28 '24 23:04 StellarBot

retest lsu

Pansysk75 avatar May 26 '24 19:05 Pansysk75

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2025-01-27T15:49:39+00:002025-05-10T18:00:08+00:00
HPX Commitaf29eae7e863b7d0f25ced593281a628e4908b69938ae94ee91dcec7e8b88a897619174c0103f7db
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile
Clusternamerostamrostam
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Datetime2025-01-27T09:56:10.969382-06:002025-05-10T13:05:16.413047-05:00

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
HPX Datetime2025-01-27T15:49:39+00:002025-05-10T18:00:08+00:00
HPX Commitaf29eae7e863b7d0f25ced593281a628e4908b69938ae94ee91dcec7e8b88a897619174c0103f7db
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile
Clusternamerostamrostam
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Datetime2025-01-27T09:58:01.174130-06:002025-05-10T13:07:09.346562-05:00

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add=(=)(=)
Stream Benchmark - Scale(=)(=)=
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2025-01-27T15:49:39+00:002025-05-10T18:00:08+00:00
HPX Commitaf29eae7e863b7d0f25ced593281a628e4908b69938ae94ee91dcec7e8b88a897619174c0103f7db
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile
Clusternamerostamrostam
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Datetime2025-01-27T09:58:21.725422-06:002025-05-10T13:07:30.428981-05:00

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

StellarBot avatar May 10 '25 18:05 StellarBot

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
HPX Commitaf29eae7e863b7d0f25ced593281a628e4908b69090dbb7f39bbffb3d6d2d6b81e6a8cd05a603acf
HPX Datetime2025-01-27T15:49:39+00:002025-05-10T18:03:59+00:00
Envfile
Clusternamerostamrostam
Datetime2025-01-27T09:56:10.969382-06:002025-05-10T13:11:02.937333-05:00
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch(=)

Info

PropertyBeforeAfter
HPX Commitaf29eae7e863b7d0f25ced593281a628e4908b69090dbb7f39bbffb3d6d2d6b81e6a8cd05a603acf
HPX Datetime2025-01-27T15:49:39+00:002025-05-10T18:03:59+00:00
Envfile
Clusternamerostamrostam
Datetime2025-01-27T09:58:01.174130-06:002025-05-10T13:12:53.455236-05:00
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)=
Stream Benchmark - Scale(=)-=
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)(=)=

Info

PropertyBeforeAfter
HPX Commitaf29eae7e863b7d0f25ced593281a628e4908b69090dbb7f39bbffb3d6d2d6b81e6a8cd05a603acf
HPX Datetime2025-01-27T15:49:39+00:002025-05-10T18:03:59+00:00
Envfile
Clusternamerostamrostam
Datetime2025-01-27T09:58:21.725422-06:002025-05-10T13:13:13.793461-05:00
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

StellarBot avatar May 10 '25 18:05 StellarBot

retest lsu

hkaiser avatar May 11 '25 15:05 hkaiser

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2025-01-27T15:49:39+00:002025-05-11T15:18:28+00:00
HPX Commitaf29eae7e863b7d0f25ced593281a628e4908b6994108b4f7e1aad1d9635c89c33f3dc606ffada51
Clusternamerostamrostam
Datetime2025-01-27T09:56:10.969382-06:002025-05-11T12:43:03.034258-05:00
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Envfile
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
HPX Datetime2025-01-27T15:49:39+00:002025-05-11T15:18:28+00:00
HPX Commitaf29eae7e863b7d0f25ced593281a628e4908b6994108b4f7e1aad1d9635c89c33f3dc606ffada51
Clusternamerostamrostam
Datetime2025-01-27T09:58:01.174130-06:002025-05-11T12:44:55.116718-05:00
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Envfile
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale(=)(=)+
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)==

Info

PropertyBeforeAfter
HPX Datetime2025-01-27T15:49:39+00:002025-05-11T15:18:28+00:00
HPX Commitaf29eae7e863b7d0f25ced593281a628e4908b6994108b4f7e1aad1d9635c89c33f3dc606ffada51
Clusternamerostamrostam
Datetime2025-01-27T09:58:21.725422-06:002025-05-11T12:45:15.561808-05:00
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Envfile
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

StellarBot avatar May 11 '25 17:05 StellarBot

This looks surprisingly good, let's merge it. @Pansysk75 ?

hkaiser avatar May 15 '25 17:05 hkaiser