Always return outermost thread id
// Re-opening of PR #6413 authored by @hkaiser
-flyby: deprecate get_outer_self_id -flyby: ignoring locks during termination detection
Coverage summary from Codacy
See diff coverage on Codacy
| Coverage variation | Diff coverage |
|---|---|
| :white_check_mark: -0.66% | :white_check_mark: 91.29% |
Coverage variation details
| Coverable lines | Covered lines | Coverage | |
|---|---|---|---|
| Common ancestor commit (b60bcf235d509e14a6979b3977b1def05d41d9c1) | 243597 | 208937 | 85.77% |
| Head commit (0deeb72b86b42aadd13631157a3c4f05ebfba503) | 193827 (-49770) | 164963 (-43974) | 85.11% (-0.66%) |
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>
Diff coverage details
| Coverable lines | Covered lines | Diff coverage | |
|---|---|---|---|
| Pull request (#6465) | 241 | 220 | 91.29% |
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%
See your quality gate settings Change summary preferences
Performance test report
HPX Performance
Comparison
| BENCHMARK | FORK_JOIN_EXECUTOR | PARALLEL_EXECUTOR | SCHEDULER_EXECUTOR |
|---|---|---|---|
| For Each | (=) | - | (=) |
Info
| Property | Before | After |
|---|---|---|
| HPX Datetime | 2024-03-18T14:00:30+00:00 | 2024-04-28T17:13:48+00:00 |
| HPX Commit | d27ac2efb17ed7a61d0417a1926ba8991f4f477f | 5e4df47e9197b21851c84965f90c95d913a741fa |
| Datetime | 2024-03-18T09:18:04.949759-05:00 | 2024-04-28T18:18:24.491797-05:00 |
| Envfile | ||
| Clustername | rostam | rostam |
| Hostname | medusa08.rostam.cct.lsu.edu | medusa08.rostam.cct.lsu.edu |
| Compiler | /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 | /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 |
Comparison
| BENCHMARK | NO-EXECUTOR |
|---|---|
| Future Overhead - Create Thread Hierarchical - Latch | (=) |
Info
| Property | Before | After |
|---|---|---|
| HPX Datetime | 2024-03-18T14:00:30+00:00 | 2024-04-28T17:13:48+00:00 |
| HPX Commit | d27ac2efb17ed7a61d0417a1926ba8991f4f477f | 5e4df47e9197b21851c84965f90c95d913a741fa |
| Datetime | 2024-03-18T09:19:53.062988-05:00 | 2024-04-28T18:20:12.047427-05:00 |
| Envfile | ||
| Clustername | rostam | rostam |
| Hostname | medusa08.rostam.cct.lsu.edu | medusa08.rostam.cct.lsu.edu |
| Compiler | /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 | /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 |
Comparison
| BENCHMARK | FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR | PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR | SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR |
|---|---|---|---|
| Stream Benchmark - Add | = | (=) | = |
| Stream Benchmark - Scale | (=) | (=) | (=) |
| Stream Benchmark - Triad | (=) | (=) | (=) |
| Stream Benchmark - Copy | = | (=) | (=) |
Info
| Property | Before | After |
|---|---|---|
| HPX Datetime | 2024-03-18T14:00:30+00:00 | 2024-04-28T17:13:48+00:00 |
| HPX Commit | d27ac2efb17ed7a61d0417a1926ba8991f4f477f | 5e4df47e9197b21851c84965f90c95d913a741fa |
| Datetime | 2024-03-18T09:20:13.002391-05:00 | 2024-04-28T18:20:28.690059-05:00 |
| Envfile | ||
| Clustername | rostam | rostam |
| Hostname | medusa08.rostam.cct.lsu.edu | medusa08.rostam.cct.lsu.edu |
| Compiler | /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 | /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 |
Explanation of Symbols
| Symbol | MEANING |
|---|---|
| = | No performance change (confidence interval within ±1%) |
| (=) | Probably no performance change (confidence interval within ±2%) |
| (+)/(-) | Very small performance improvement/degradation (≤1%) |
| +/- | Small performance improvement/degradation (≤5%) |
| ++/-- | Large performance improvement/degradation (≤10%) |
| +++/--- | Very large performance improvement/degradation (>10%) |
| ? | Probably no change, but quite large uncertainty (confidence interval with ±5%) |
| ?? | Unclear result, very large uncertainty (±10%) |
| ??? | Something unexpected… |
retest lsu
Performance test report
HPX Performance
Comparison
| BENCHMARK | FORK_JOIN_EXECUTOR | PARALLEL_EXECUTOR | SCHEDULER_EXECUTOR |
|---|---|---|---|
| For Each | (=) | (=) | (=) |
Info
| Property | Before | After |
|---|---|---|
| HPX Datetime | 2025-01-27T15:49:39+00:00 | 2025-05-10T18:00:08+00:00 |
| HPX Commit | af29eae7e863b7d0f25ced593281a628e4908b69 | 938ae94ee91dcec7e8b88a897619174c0103f7db |
| Hostname | medusa08.rostam.cct.lsu.edu | medusa08.rostam.cct.lsu.edu |
| Envfile | ||
| Clustername | rostam | rostam |
| Compiler | /opt/apps/llvm/18.1.8/bin/clang++ 18.1.8 | /opt/apps/llvm/18.1.8/bin/clang++ 18.1.8 |
| Datetime | 2025-01-27T09:56:10.969382-06:00 | 2025-05-10T13:05:16.413047-05:00 |
Comparison
| BENCHMARK | NO-EXECUTOR |
|---|---|
| Future Overhead - Create Thread Hierarchical - Latch | - |
Info
| Property | Before | After |
|---|---|---|
| HPX Datetime | 2025-01-27T15:49:39+00:00 | 2025-05-10T18:00:08+00:00 |
| HPX Commit | af29eae7e863b7d0f25ced593281a628e4908b69 | 938ae94ee91dcec7e8b88a897619174c0103f7db |
| Hostname | medusa08.rostam.cct.lsu.edu | medusa08.rostam.cct.lsu.edu |
| Envfile | ||
| Clustername | rostam | rostam |
| Compiler | /opt/apps/llvm/18.1.8/bin/clang++ 18.1.8 | /opt/apps/llvm/18.1.8/bin/clang++ 18.1.8 |
| Datetime | 2025-01-27T09:58:01.174130-06:00 | 2025-05-10T13:07:09.346562-05:00 |
Comparison
| BENCHMARK | FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR | PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR | SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR |
|---|---|---|---|
| Stream Benchmark - Add | = | (=) | (=) |
| Stream Benchmark - Scale | (=) | (=) | = |
| Stream Benchmark - Triad | (=) | (=) | (=) |
| Stream Benchmark - Copy | (=) | (=) | (=) |
Info
| Property | Before | After |
|---|---|---|
| HPX Datetime | 2025-01-27T15:49:39+00:00 | 2025-05-10T18:00:08+00:00 |
| HPX Commit | af29eae7e863b7d0f25ced593281a628e4908b69 | 938ae94ee91dcec7e8b88a897619174c0103f7db |
| Hostname | medusa08.rostam.cct.lsu.edu | medusa08.rostam.cct.lsu.edu |
| Envfile | ||
| Clustername | rostam | rostam |
| Compiler | /opt/apps/llvm/18.1.8/bin/clang++ 18.1.8 | /opt/apps/llvm/18.1.8/bin/clang++ 18.1.8 |
| Datetime | 2025-01-27T09:58:21.725422-06:00 | 2025-05-10T13:07:30.428981-05:00 |
Explanation of Symbols
| Symbol | MEANING |
|---|---|
| = | No performance change (confidence interval within ±1%) |
| (=) | Probably no performance change (confidence interval within ±2%) |
| (+)/(-) | Very small performance improvement/degradation (≤1%) |
| +/- | Small performance improvement/degradation (≤5%) |
| ++/-- | Large performance improvement/degradation (≤10%) |
| +++/--- | Very large performance improvement/degradation (>10%) |
| ? | Probably no change, but quite large uncertainty (confidence interval with ±5%) |
| ?? | Unclear result, very large uncertainty (±10%) |
| ??? | Something unexpected… |
Performance test report
HPX Performance
Comparison
| BENCHMARK | FORK_JOIN_EXECUTOR | PARALLEL_EXECUTOR | SCHEDULER_EXECUTOR |
|---|---|---|---|
| For Each | (=) | (=) | (=) |
Info
| Property | Before | After |
|---|---|---|
| HPX Commit | af29eae7e863b7d0f25ced593281a628e4908b69 | 090dbb7f39bbffb3d6d2d6b81e6a8cd05a603acf |
| HPX Datetime | 2025-01-27T15:49:39+00:00 | 2025-05-10T18:03:59+00:00 |
| Envfile | ||
| Clustername | rostam | rostam |
| Datetime | 2025-01-27T09:56:10.969382-06:00 | 2025-05-10T13:11:02.937333-05:00 |
| Compiler | /opt/apps/llvm/18.1.8/bin/clang++ 18.1.8 | /opt/apps/llvm/18.1.8/bin/clang++ 18.1.8 |
| Hostname | medusa08.rostam.cct.lsu.edu | medusa08.rostam.cct.lsu.edu |
Comparison
| BENCHMARK | NO-EXECUTOR |
|---|---|
| Future Overhead - Create Thread Hierarchical - Latch | (=) |
Info
| Property | Before | After |
|---|---|---|
| HPX Commit | af29eae7e863b7d0f25ced593281a628e4908b69 | 090dbb7f39bbffb3d6d2d6b81e6a8cd05a603acf |
| HPX Datetime | 2025-01-27T15:49:39+00:00 | 2025-05-10T18:03:59+00:00 |
| Envfile | ||
| Clustername | rostam | rostam |
| Datetime | 2025-01-27T09:58:01.174130-06:00 | 2025-05-10T13:12:53.455236-05:00 |
| Compiler | /opt/apps/llvm/18.1.8/bin/clang++ 18.1.8 | /opt/apps/llvm/18.1.8/bin/clang++ 18.1.8 |
| Hostname | medusa08.rostam.cct.lsu.edu | medusa08.rostam.cct.lsu.edu |
Comparison
| BENCHMARK | FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR | PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR | SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR |
|---|---|---|---|
| Stream Benchmark - Add | (=) | (=) | = |
| Stream Benchmark - Scale | (=) | - | = |
| Stream Benchmark - Triad | (=) | (=) | (=) |
| Stream Benchmark - Copy | (=) | (=) | = |
Info
| Property | Before | After |
|---|---|---|
| HPX Commit | af29eae7e863b7d0f25ced593281a628e4908b69 | 090dbb7f39bbffb3d6d2d6b81e6a8cd05a603acf |
| HPX Datetime | 2025-01-27T15:49:39+00:00 | 2025-05-10T18:03:59+00:00 |
| Envfile | ||
| Clustername | rostam | rostam |
| Datetime | 2025-01-27T09:58:21.725422-06:00 | 2025-05-10T13:13:13.793461-05:00 |
| Compiler | /opt/apps/llvm/18.1.8/bin/clang++ 18.1.8 | /opt/apps/llvm/18.1.8/bin/clang++ 18.1.8 |
| Hostname | medusa08.rostam.cct.lsu.edu | medusa08.rostam.cct.lsu.edu |
Explanation of Symbols
| Symbol | MEANING |
|---|---|
| = | No performance change (confidence interval within ±1%) |
| (=) | Probably no performance change (confidence interval within ±2%) |
| (+)/(-) | Very small performance improvement/degradation (≤1%) |
| +/- | Small performance improvement/degradation (≤5%) |
| ++/-- | Large performance improvement/degradation (≤10%) |
| +++/--- | Very large performance improvement/degradation (>10%) |
| ? | Probably no change, but quite large uncertainty (confidence interval with ±5%) |
| ?? | Unclear result, very large uncertainty (±10%) |
| ??? | Something unexpected… |
retest lsu
Performance test report
HPX Performance
Comparison
| BENCHMARK | FORK_JOIN_EXECUTOR | PARALLEL_EXECUTOR | SCHEDULER_EXECUTOR |
|---|---|---|---|
| For Each | (=) | (=) | (=) |
Info
| Property | Before | After |
|---|---|---|
| HPX Datetime | 2025-01-27T15:49:39+00:00 | 2025-05-11T15:18:28+00:00 |
| HPX Commit | af29eae7e863b7d0f25ced593281a628e4908b69 | 94108b4f7e1aad1d9635c89c33f3dc606ffada51 |
| Clustername | rostam | rostam |
| Datetime | 2025-01-27T09:56:10.969382-06:00 | 2025-05-11T12:43:03.034258-05:00 |
| Compiler | /opt/apps/llvm/18.1.8/bin/clang++ 18.1.8 | /opt/apps/llvm/18.1.8/bin/clang++ 18.1.8 |
| Envfile | ||
| Hostname | medusa08.rostam.cct.lsu.edu | medusa08.rostam.cct.lsu.edu |
Comparison
| BENCHMARK | NO-EXECUTOR |
|---|---|
| Future Overhead - Create Thread Hierarchical - Latch | - |
Info
| Property | Before | After |
|---|---|---|
| HPX Datetime | 2025-01-27T15:49:39+00:00 | 2025-05-11T15:18:28+00:00 |
| HPX Commit | af29eae7e863b7d0f25ced593281a628e4908b69 | 94108b4f7e1aad1d9635c89c33f3dc606ffada51 |
| Clustername | rostam | rostam |
| Datetime | 2025-01-27T09:58:01.174130-06:00 | 2025-05-11T12:44:55.116718-05:00 |
| Compiler | /opt/apps/llvm/18.1.8/bin/clang++ 18.1.8 | /opt/apps/llvm/18.1.8/bin/clang++ 18.1.8 |
| Envfile | ||
| Hostname | medusa08.rostam.cct.lsu.edu | medusa08.rostam.cct.lsu.edu |
Comparison
| BENCHMARK | FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR | PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR | SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR |
|---|---|---|---|
| Stream Benchmark - Add | (=) | (=) | (=) |
| Stream Benchmark - Scale | (=) | (=) | + |
| Stream Benchmark - Triad | (=) | (=) | (=) |
| Stream Benchmark - Copy | (=) | = | = |
Info
| Property | Before | After |
|---|---|---|
| HPX Datetime | 2025-01-27T15:49:39+00:00 | 2025-05-11T15:18:28+00:00 |
| HPX Commit | af29eae7e863b7d0f25ced593281a628e4908b69 | 94108b4f7e1aad1d9635c89c33f3dc606ffada51 |
| Clustername | rostam | rostam |
| Datetime | 2025-01-27T09:58:21.725422-06:00 | 2025-05-11T12:45:15.561808-05:00 |
| Compiler | /opt/apps/llvm/18.1.8/bin/clang++ 18.1.8 | /opt/apps/llvm/18.1.8/bin/clang++ 18.1.8 |
| Envfile | ||
| Hostname | medusa08.rostam.cct.lsu.edu | medusa08.rostam.cct.lsu.edu |
Explanation of Symbols
| Symbol | MEANING |
|---|---|
| = | No performance change (confidence interval within ±1%) |
| (=) | Probably no performance change (confidence interval within ±2%) |
| (+)/(-) | Very small performance improvement/degradation (≤1%) |
| +/- | Small performance improvement/degradation (≤5%) |
| ++/-- | Large performance improvement/degradation (≤10%) |
| +++/--- | Very large performance improvement/degradation (>10%) |
| ? | Probably no change, but quite large uncertainty (confidence interval with ±5%) |
| ?? | Unclear result, very large uncertainty (±10%) |
| ??? | Something unexpected… |
This looks surprisingly good, let's merge it. @Pansysk75 ?