hpx icon indicating copy to clipboard operation
hpx copied to clipboard

Always return outermost thread id

Open hkaiser opened this issue 1 year ago • 3 comments

-flyby: deprecate get_outer_self_id

fixing #6333

hkaiser avatar Jan 12 '24 21:01 hkaiser

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.04% :white_check_mark: 91.39%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5a0ba83f417c760d60c3217993367e1453d0dbb2) 215961 183719 85.07%
Head commit (a627ae24a1f542d82860f3c63492a37fe39ad4a8) 190554 (-25407) 162178 (-21541) 85.11% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6413) 244 223 91.39%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

codacy-production[bot] avatar Jan 13 '24 04:01 codacy-production[bot]

retest lsu

hkaiser avatar Jan 18 '24 15:01 hkaiser

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)??-

Info

PropertyBeforeAfter
HPX Datetime2023-05-10T12:07:53+00:002024-01-18T15:34:29+00:00
HPX Commitdcb541576898d370113946ba15fb58c20c8325b2f1abe2620133f03cbe75e0ba0512241228fa3974
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Clusternamerostamrostam
Datetime2023-05-10T14:50:18.616050-05:002024-01-18T09:39:59.830539-06:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch=

Info

PropertyBeforeAfter
HPX Datetime2023-05-10T12:07:53+00:002024-01-18T15:34:29+00:00
HPX Commitdcb541576898d370113946ba15fb58c20c8325b2f1abe2620133f03cbe75e0ba0512241228fa3974
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Clusternamerostamrostam
Datetime2023-05-10T14:52:35.047119-05:002024-01-18T09:42:13.571711-06:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale+(=)(=)
Stream Benchmark - Triad(=)=(=)
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2023-05-10T12:07:53+00:002024-01-18T15:34:29+00:00
HPX Commitdcb541576898d370113946ba15fb58c20c8325b2f1abe2620133f03cbe75e0ba0512241228fa3974
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Clusternamerostamrostam
Datetime2023-05-10T14:52:52.237641-05:002024-01-18T09:42:30.389000-06:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

StellarBot avatar Jan 18 '24 15:01 StellarBot

The freelist error has been fixed by #6458

hkaiser avatar Mar 20 '24 14:03 hkaiser