hpx icon indicating copy to clipboard operation
hpx copied to clipboard

resolve CI test breaking gasnet issues

Open ct-clmsn opened this issue 2 years ago • 10 comments

Fixes #6385

Proposed Changes

  • modify builders to use gasnet-mpi
  • modify the hpxrun script to use mpiexec when testing gasnet-mpi
  • update the gasnet environment logic to enable or disable gasnet

Any background context you want to provide?

the gasnet parcelport was merged into hpx and had started causing other parcelport tests to silently fail

Checklist

Not all points below apply to all pull requests.

  • [x] I have added a new feature and have added tests to go along with it.
  • [x] I have fixed a bug and have added a regression test.

ct-clmsn avatar Nov 10 '23 02:11 ct-clmsn

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.07%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5ffdfbe2a1b1b561adccad301ae3fd0140acfe0b) 193075 164320 85.11%
Head commit (8877fede07000e1b803e1930ed8bf5190c948451) 190055 (-3020) 161877 (-2443) 85.17% (+0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6386) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

codacy-production[bot] avatar Nov 10 '23 07:11 codacy-production[bot]

retest lsu

Pansysk75 avatar Nov 22 '23 23:11 Pansysk75

retest

Pansysk75 avatar Dec 11 '23 17:12 Pansysk75

@Pansysk75, @ct-clmsn: what is the state of this PR? Did we ever manage to get the gasnet parcelport working properly?

hkaiser avatar Jan 14 '24 14:01 hkaiser

@hkaiser I've had issues accessing the execution logs when the application fails runtime checks. I'll be pushing to complete this on a separate cluster at the top of the week.

ct-clmsn avatar Jan 14 '24 15:01 ct-clmsn

@hkaiser I've had issues accessing the execution logs when the application fails runtime checks. I'll be pushing to complete this on a separate cluster at the top of the week.

Yes, the CSCS CDash is a bit unreliable, currently. We're in the process of moving it to Rostam.

hkaiser avatar Jan 14 '24 15:01 hkaiser

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.44% :white_check_mark:
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5ffdfbe2a1b1b561adccad301ae3fd0140acfe0b) 0 0 84.57%
Head commit (b5694fcac43dd29b99b7a37c0b4815ddf562acc2) 189565 (+189565) 161149 (+161149) 85.01% (+0.44%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6386) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

codacy-production[bot] avatar Feb 22 '24 05:02 codacy-production[bot]

@ct-clmsn could you please rebase this onto master? This will give us an understanding of what works (and what doesn't). Thanks!

hkaiser avatar Apr 28 '24 16:04 hkaiser

@hkaiser will do; currently working with @constracktor on debugging this branch

ct-clmsn avatar Apr 28 '24 16:04 ct-clmsn

@hkaiser will do; currently working with @constracktor on debugging this branch

Thanks. I'll leave this PR for now on track for the upcomming V1.10.0 release.

hkaiser avatar May 03 '24 15:05 hkaiser