Simd Find
Open
Johan511
opened this issue 1 year ago
•
10 comments
using simd-helpers (from #6286 ) to add vectorization to stl algorithms
Speedups observed for seq vs unseq
Nice!
Performance test report HPX Performance Comparison BENCHMARK FORK_JOIN_EXECUTOR PARALLEL_EXECUTOR SCHEDULER_EXECUTOR For Each (=) ?? -
Info Property Before After HPX Datetime 2023-05-10T12:07:53+00:00 2023-08-08T21:21:49+00:00 HPX Commit dcb541576898d370113946ba15fb58c20c8325b2 f524d6e6bd33daf288c034dce2ea88891e4a403a Clustername rostam rostam Datetime 2023-05-10T14:50:18.616050-05:00 2023-08-08T16:30:27.710089-05:00 Hostname medusa08.rostam.cct.lsu.edu medusa08.rostam.cct.lsu.edu Compiler /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 Envfile
Comparison BENCHMARK NO-EXECUTOR Future Overhead - Create Thread Hierarchical - Latch =
Info Property Before After HPX Datetime 2023-05-10T12:07:53+00:00 2023-08-08T21:21:49+00:00 HPX Commit dcb541576898d370113946ba15fb58c20c8325b2 f524d6e6bd33daf288c034dce2ea88891e4a403a Clustername rostam rostam Datetime 2023-05-10T14:52:35.047119-05:00 2023-08-08T16:32:40.990850-05:00 Hostname medusa08.rostam.cct.lsu.edu medusa08.rostam.cct.lsu.edu Compiler /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 Envfile
Comparison BENCHMARK FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR Stream Benchmark - Add (=) (=) (=) Stream Benchmark - Scale (=) (=) (=) Stream Benchmark - Triad (=) (=) (=) Stream Benchmark - Copy (=) (=) (=)
Info Property Before After HPX Datetime 2023-05-10T12:07:53+00:00 2023-08-08T21:21:49+00:00 HPX Commit dcb541576898d370113946ba15fb58c20c8325b2 f524d6e6bd33daf288c034dce2ea88891e4a403a Clustername rostam rostam Datetime 2023-05-10T14:52:52.237641-05:00 2023-08-08T16:32:57.921975-05:00 Hostname medusa08.rostam.cct.lsu.edu medusa08.rostam.cct.lsu.edu Compiler /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 Envfile
Explanation of Symbols Symbol MEANING = No performance change (confidence interval within ±1%) (=) Probably no performance change (confidence interval within ±2%) (+)/(-) Very small performance improvement/degradation (≤1%) +/- Small performance improvement/degradation (≤5%) ++/-- Large performance improvement/degradation (≤10%) +++/--- Very large performance improvement/degradation (>10%) ? Probably no change, but quite large uncertainty (confidence interval with ±5%) ?? Unclear result, very large uncertainty (±10%) ??? Something unexpected…
Performance test report HPX Performance Comparison BENCHMARK FORK_JOIN_EXECUTOR PARALLEL_EXECUTOR SCHEDULER_EXECUTOR For Each (=) ?? -
Info Property Before After HPX Datetime 2023-05-10T12:07:53+00:00 2023-08-08T21:33:54+00:00 HPX Commit dcb541576898d370113946ba15fb58c20c8325b2 f663f5220a313ce6ec41075cd71fccd7ae75de7b Datetime 2023-05-10T14:50:18.616050-05:00 2023-08-08T16:40:03.129538-05:00 Clustername rostam rostam Hostname medusa08.rostam.cct.lsu.edu medusa08.rostam.cct.lsu.edu Envfile Compiler /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Comparison BENCHMARK NO-EXECUTOR Future Overhead - Create Thread Hierarchical - Latch (=)
Info Property Before After HPX Datetime 2023-05-10T12:07:53+00:00 2023-08-08T21:33:54+00:00 HPX Commit dcb541576898d370113946ba15fb58c20c8325b2 f663f5220a313ce6ec41075cd71fccd7ae75de7b Datetime 2023-05-10T14:52:35.047119-05:00 2023-08-08T16:42:16.273814-05:00 Clustername rostam rostam Hostname medusa08.rostam.cct.lsu.edu medusa08.rostam.cct.lsu.edu Envfile Compiler /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Comparison BENCHMARK FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR Stream Benchmark - Add (=) (=) (=) Stream Benchmark - Scale (=) (=) (=) Stream Benchmark - Triad (=) (=) (=) Stream Benchmark - Copy (=) (=) (=)
Info Property Before After HPX Datetime 2023-05-10T12:07:53+00:00 2023-08-08T21:33:54+00:00 HPX Commit dcb541576898d370113946ba15fb58c20c8325b2 f663f5220a313ce6ec41075cd71fccd7ae75de7b Datetime 2023-05-10T14:52:52.237641-05:00 2023-08-08T16:42:33.204088-05:00 Clustername rostam rostam Hostname medusa08.rostam.cct.lsu.edu medusa08.rostam.cct.lsu.edu Envfile Compiler /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Explanation of Symbols Symbol MEANING = No performance change (confidence interval within ±1%) (=) Probably no performance change (confidence interval within ±2%) (+)/(-) Very small performance improvement/degradation (≤1%) +/- Small performance improvement/degradation (≤5%) ++/-- Large performance improvement/degradation (≤10%) +++/--- Very large performance improvement/degradation (>10%) ? Probably no change, but quite large uncertainty (confidence interval with ±5%) ?? Unclear result, very large uncertainty (±10%) ??? Something unexpected…
Performance test report HPX Performance Comparison BENCHMARK FORK_JOIN_EXECUTOR PARALLEL_EXECUTOR SCHEDULER_EXECUTOR For Each (=) ?? -
Info Property Before After HPX Datetime 2023-05-10T12:07:53+00:00 2023-08-09T06:33:19+00:00 HPX Commit dcb541576898d370113946ba15fb58c20c8325b2 17aba859da967b92bc5644b200c41c8450b815ce Clustername rostam rostam Compiler /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 Hostname medusa08.rostam.cct.lsu.edu medusa08.rostam.cct.lsu.edu Datetime 2023-05-10T14:50:18.616050-05:00 2023-08-09T01:40:37.750853-05:00 Envfile
Comparison BENCHMARK NO-EXECUTOR Future Overhead - Create Thread Hierarchical - Latch (=)
Info Property Before After HPX Datetime 2023-05-10T12:07:53+00:00 2023-08-09T06:33:19+00:00 HPX Commit dcb541576898d370113946ba15fb58c20c8325b2 17aba859da967b92bc5644b200c41c8450b815ce Clustername rostam rostam Compiler /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 Hostname medusa08.rostam.cct.lsu.edu medusa08.rostam.cct.lsu.edu Datetime 2023-05-10T14:52:35.047119-05:00 2023-08-09T01:42:50.859516-05:00 Envfile
Comparison BENCHMARK FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR Stream Benchmark - Add (=) (=) (=) Stream Benchmark - Scale (=) (=) (=) Stream Benchmark - Triad = (=) (=) Stream Benchmark - Copy (=) (=) (=)
Info Property Before After HPX Datetime 2023-05-10T12:07:53+00:00 2023-08-09T06:33:19+00:00 HPX Commit dcb541576898d370113946ba15fb58c20c8325b2 17aba859da967b92bc5644b200c41c8450b815ce Clustername rostam rostam Compiler /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 Hostname medusa08.rostam.cct.lsu.edu medusa08.rostam.cct.lsu.edu Datetime 2023-05-10T14:52:52.237641-05:00 2023-08-09T01:43:07.824650-05:00 Envfile
Explanation of Symbols Symbol MEANING = No performance change (confidence interval within ±1%) (=) Probably no performance change (confidence interval within ±2%) (+)/(-) Very small performance improvement/degradation (≤1%) +/- Small performance improvement/degradation (≤5%) ++/-- Large performance improvement/degradation (≤10%) +++/--- Very large performance improvement/degradation (>10%) ? Probably no change, but quite large uncertainty (confidence interval with ±5%) ?? Unclear result, very large uncertainty (±10%) ??? Something unexpected…
@Johan511 could you please fix the reported clang-format issues as well?
@Johan511 could you please fix the reported clang-format issues as well?
There is one loop yet to be vectorized, once that's done vectorization should be enabled for parallel case too. We can merge after that.
Performance test report HPX Performance Comparison BENCHMARK FORK_JOIN_EXECUTOR PARALLEL_EXECUTOR SCHEDULER_EXECUTOR For Each (=) ?? -
Info Property Before After HPX Datetime 2023-05-10T12:07:53+00:00 2023-08-11T12:14:49+00:00 HPX Commit dcb541576898d370113946ba15fb58c20c8325b2 5cccf76d5c51772440fa5320955bba39086d077f Datetime 2023-05-10T14:50:18.616050-05:00 2023-08-11T07:20:22.167797-05:00 Compiler /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 Envfile Clustername rostam rostam Hostname medusa08.rostam.cct.lsu.edu medusa08.rostam.cct.lsu.edu
Comparison BENCHMARK NO-EXECUTOR Future Overhead - Create Thread Hierarchical - Latch (=)
Info Property Before After HPX Datetime 2023-05-10T12:07:53+00:00 2023-08-11T12:14:49+00:00 HPX Commit dcb541576898d370113946ba15fb58c20c8325b2 5cccf76d5c51772440fa5320955bba39086d077f Datetime 2023-05-10T14:52:35.047119-05:00 2023-08-11T07:22:34.867171-05:00 Compiler /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 Envfile Clustername rostam rostam Hostname medusa08.rostam.cct.lsu.edu medusa08.rostam.cct.lsu.edu
Comparison BENCHMARK FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR Stream Benchmark - Add (=) (=) (=) Stream Benchmark - Scale (=) (=) = Stream Benchmark - Triad = (=) (=) Stream Benchmark - Copy (=) - (=)
Info Property Before After HPX Datetime 2023-05-10T12:07:53+00:00 2023-08-11T12:14:49+00:00 HPX Commit dcb541576898d370113946ba15fb58c20c8325b2 5cccf76d5c51772440fa5320955bba39086d077f Datetime 2023-05-10T14:52:52.237641-05:00 2023-08-11T07:22:51.879951-05:00 Compiler /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 /opt/apps/llvm/13.0.1/bin/clang++ 13.0.1 Envfile Clustername rostam rostam Hostname medusa08.rostam.cct.lsu.edu medusa08.rostam.cct.lsu.edu
Explanation of Symbols Symbol MEANING = No performance change (confidence interval within ±1%) (=) Probably no performance change (confidence interval within ±2%) (+)/(-) Very small performance improvement/degradation (≤1%) +/- Small performance improvement/degradation (≤5%) ++/-- Large performance improvement/degradation (≤10%) +++/--- Very large performance improvement/degradation (>10%) ? Probably no change, but quite large uncertainty (confidence interval with ±5%) ?? Unclear result, very large uncertainty (±10%) ??? Something unexpected…
@hkaiser the unseq_first_n function has been changed a bit, the the function now takes iterator as input instead of value, this does not break vectorization.
Coverage summary from Codacy
Coverage variation
Diff coverage
:white_check_mark: -0.10%
:white_check_mark: 80.00%
Coverage variation details
Coverable lines
Covered lines
Coverage
Common ancestor commit (17bdd0d04b7d06be59e017cdcb125b1078d31c81)
206733
176202
85.23%
Head commit (d8096f0a3173a594c21cf6df1a993f39c5302ad1)
190774 (-15959)
162418 (-13784)
85.14% (-0.10% )
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>
Diff coverage details
Coverable lines
Covered lines
Diff coverage
Pull request (#6302)
10
8
80.00%
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%
You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation
hpx copied to clipboard
STEllAR-GROUP
![codacy-production[bot] avatar](https://avatars.githubusercontent.com/in/56611?v=4 "Published by a pub.dev verified publisher"){kind=small}