hpx icon indicating copy to clipboard operation
hpx copied to clipboard

Published 20 hours ago • verified publisher icon STEllAR-GROUP

Integrating sync_wait & sync_wait_with_variant

Open hcq9102 opened this issue 2 years ago • 3 comments

Proposed Changes:

Ref: P2300R5 Integrate sync_wait and sync_wait_with_variant.

Checklist

  • I have added a new feature and have added tests to go along with it.

hcq9102 avatar Sep 18 '22 17:09 hcq9102

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2022-05-31T12:57:29+00:002022-09-19T22:13:18+00:00
HPX Commitd5655f89770ba953e8de3ceb349567d5fcb74a959fff673ebcc901e6b3ac67d12a44e2f6ce312f7c
Clusternamedaintdaint
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile
Hostnamenid01193nid00876
Datetime2022-05-31T15:13:01.357969+02:002022-09-20T00:27:10.756628+02:00

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch(=)

Info

PropertyBeforeAfter
HPX Datetime2022-05-31T12:57:29+00:002022-09-19T22:13:18+00:00
HPX Commitd5655f89770ba953e8de3ceb349567d5fcb74a959fff673ebcc901e6b3ac67d12a44e2f6ce312f7c
Clusternamedaintdaint
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile
Hostnamenid01193nid00876
Datetime2022-05-31T15:13:18.026239+02:002022-09-20T00:27:27.376396+02:00

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)--
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad(=)(=)-
Stream Benchmark - Copy(=)=(=)

Info

PropertyBeforeAfter
HPX Datetime2021-11-10T19:14:21+00:002022-09-19T22:13:18+00:00
HPX Commit71d8dbe40b737be02ea734f9d98fcc0b1e21f01a9fff673ebcc901e6b3ac67d12a44e2f6ce312f7c
Clusternamedaintdaint
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile
Hostnamenid00120nid00876
Datetime2021-11-10T20:28:18.266961+01:002022-09-20T00:27:42.743177+02:00

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

StellarBot avatar Sep 19 '22 22:09 StellarBot

@hcq9102 do we still need to merge #5956 before merging this?

hkaiser avatar Sep 21 '22 21:09 hkaiser

@hcq9102 do we still need to merge #5956 before merging this?

I think we don't need #5956 anymore. But I would like to close #5956 after this PR is merged.

hcq9102 avatar Sep 21 '22 21:09 hcq9102

@hcq9102 this should be fine now. Please note that I have also rebased (and force-pushed) this PR onto master.

hkaiser avatar Sep 30 '22 17:09 hkaiser

bors merge

hkaiser avatar Oct 05 '22 18:10 hkaiser

Build succeeded:

  • Bors

bors[bot] avatar Oct 05 '22 19:10 bors[bot]