hpx icon indicating copy to clipboard operation
hpx copied to clipboard

Adding sync_wait_with_variant

Open hcq9102 opened this issue 2 years ago • 9 comments

Any background context you want to provide?

P2300R5: sync_wait_with_variant sync_wait_with_variant, which accepts any sender, but returns an optional whose value type is the variant of all the possible tuples sent by the input sender:

Checklist

  • [x] I have added a new feature and have added tests to go along with it.

hcq9102 avatar Jul 17 '22 05:07 hcq9102

Also, now that you have a working version that duplicates 95% of the sync_wait code, would you see a way to combine the implementations of sync_wait and sync_wait_with_variant to reduce the amount of code repetition?

Sure, will do.

hcq9102 avatar Jul 17 '22 19:07 hcq9102

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2022-05-31T12:57:29+00:002022-07-18T15:18:52+00:00
HPX Commitd5655f89770ba953e8de3ceb349567d5fcb74a9532c79274846535f93521e2f0c09f6e3c33857b77
Datetime2022-05-31T15:13:01.357969+02:002022-07-18T17:31:13.698133+02:00
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Hostnamenid01193nid01193
Clusternamedaintdaint
Envfile

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch=

Info

PropertyBeforeAfter
HPX Datetime2022-05-31T12:57:29+00:002022-07-18T15:18:52+00:00
HPX Commitd5655f89770ba953e8de3ceb349567d5fcb74a9532c79274846535f93521e2f0c09f6e3c33857b77
Datetime2022-05-31T15:13:18.026239+02:002022-07-18T17:31:30.343351+02:00
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Hostnamenid01193nid01193
Clusternamedaintdaint
Envfile

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)-(=)
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2021-11-10T19:14:21+00:002022-07-18T15:18:52+00:00
HPX Commit71d8dbe40b737be02ea734f9d98fcc0b1e21f01a32c79274846535f93521e2f0c09f6e3c33857b77
Datetime2021-11-10T20:28:18.266961+01:002022-07-18T17:31:45.627798+02:00
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Hostnamenid00120nid01193
Clusternamedaintdaint
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

StellarBot avatar Jul 18 '22 15:07 StellarBot

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)=(=)

Info

PropertyBeforeAfter
HPX Datetime2022-05-31T12:57:29+00:002022-07-18T15:33:17+00:00
HPX Commitd5655f89770ba953e8de3ceb349567d5fcb74a9544ef1d3194206fbe00bf91155955ef633b197770
Hostnamenid01193nid00435
Clusternamedaintdaint
Datetime2022-05-31T15:13:01.357969+02:002022-07-18T17:47:08.838396+02:00
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch=

Info

PropertyBeforeAfter
HPX Datetime2022-05-31T12:57:29+00:002022-07-18T15:33:17+00:00
HPX Commitd5655f89770ba953e8de3ceb349567d5fcb74a9544ef1d3194206fbe00bf91155955ef633b197770
Hostnamenid01193nid00435
Clusternamedaintdaint
Datetime2022-05-31T15:13:18.026239+02:002022-07-18T17:47:25.501653+02:00
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)-(=)

Info

PropertyBeforeAfter
HPX Datetime2021-11-10T19:14:21+00:002022-07-18T15:33:17+00:00
HPX Commit71d8dbe40b737be02ea734f9d98fcc0b1e21f01a44ef1d3194206fbe00bf91155955ef633b197770
Hostnamenid00120nid00435
Clusternamedaintdaint
Datetime2021-11-10T20:28:18.266961+01:002022-07-18T17:47:40.865125+02:00
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

StellarBot avatar Jul 18 '22 15:07 StellarBot

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
HPX Commitd5655f89770ba953e8de3ceb349567d5fcb74a95258527e18e1e92797cfb624c87d248a63d461997
HPX Datetime2022-05-31T12:57:29+00:002022-07-19T16:50:56+00:00
Datetime2022-05-31T15:13:01.357969+02:002022-07-19T19:11:51.673858+02:00
Envfile
Clusternamedaintdaint
Hostnamenid01193nid01323
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
HPX Commitd5655f89770ba953e8de3ceb349567d5fcb74a95258527e18e1e92797cfb624c87d248a63d461997
HPX Datetime2022-05-31T12:57:29+00:002022-07-19T16:50:56+00:00
Datetime2022-05-31T15:13:18.026239+02:002022-07-19T19:12:08.672710+02:00
Envfile
Clusternamedaintdaint
Hostnamenid01193nid01323
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)-(=)
Stream Benchmark - Scale(=)(=)=
Stream Benchmark - Triad(=)-(=)
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
HPX Commit71d8dbe40b737be02ea734f9d98fcc0b1e21f01a258527e18e1e92797cfb624c87d248a63d461997
HPX Datetime2021-11-10T19:14:21+00:002022-07-19T16:50:56+00:00
Datetime2021-11-10T20:28:18.266961+01:002022-07-19T19:12:24.086403+02:00
Envfile
Clusternamedaintdaint
Hostnamenid00120nid01323
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

StellarBot avatar Jul 19 '22 17:07 StellarBot

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)=(=)

Info

PropertyBeforeAfter
HPX Commitd5655f89770ba953e8de3ceb349567d5fcb74a958204a4e9486723f7c374924d209a682ae3409441
HPX Datetime2022-05-31T12:57:29+00:002022-07-24T14:20:55+00:00
Clusternamedaintdaint
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Hostnamenid01193nid01260
Datetime2022-05-31T15:13:01.357969+02:002022-07-24T16:36:41.128162+02:00
Envfile

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
HPX Commitd5655f89770ba953e8de3ceb349567d5fcb74a958204a4e9486723f7c374924d209a682ae3409441
HPX Datetime2022-05-31T12:57:29+00:002022-07-24T14:20:55+00:00
Clusternamedaintdaint
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Hostnamenid01193nid01260
Datetime2022-05-31T15:13:18.026239+02:002022-07-24T16:36:58.275781+02:00
Envfile

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)-(=)
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad-(=)(=)
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
HPX Commit71d8dbe40b737be02ea734f9d98fcc0b1e21f01a8204a4e9486723f7c374924d209a682ae3409441
HPX Datetime2021-11-10T19:14:21+00:002022-07-24T14:20:55+00:00
Clusternamedaintdaint
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Hostnamenid00120nid01260
Datetime2021-11-10T20:28:18.266961+01:002022-07-24T16:37:13.706292+02:00
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

StellarBot avatar Jul 24 '22 14:07 StellarBot

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)=(=)

Info

PropertyBeforeAfter
HPX Datetime2022-05-31T12:57:29+00:002022-07-31T14:05:57+00:00
HPX Commitd5655f89770ba953e8de3ceb349567d5fcb74a95a866cc4e205b418aae54a0e3323f8cc8eec40d03
Hostnamenid01193nid01193
Datetime2022-05-31T15:13:01.357969+02:002022-07-31T16:22:36.824275+02:00
Clusternamedaintdaint
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch(=)

Info

PropertyBeforeAfter
HPX Datetime2022-05-31T12:57:29+00:002022-07-31T14:05:57+00:00
HPX Commitd5655f89770ba953e8de3ceb349567d5fcb74a95a866cc4e205b418aae54a0e3323f8cc8eec40d03
Hostnamenid01193nid01193
Datetime2022-05-31T15:13:18.026239+02:002022-07-31T16:22:53.800696+02:00
Clusternamedaintdaint
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)-(=)
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad(=)-(=)
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2021-11-10T19:14:21+00:002022-07-31T14:05:57+00:00
HPX Commit71d8dbe40b737be02ea734f9d98fcc0b1e21f01aa866cc4e205b418aae54a0e3323f8cc8eec40d03
Hostnamenid00120nid01193
Datetime2021-11-10T20:28:18.266961+01:002022-07-31T16:23:09.089371+02:00
Clusternamedaintdaint
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

StellarBot avatar Jul 31 '22 14:07 StellarBot

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2022-05-31T12:57:29+00:002022-08-10T18:11:09+00:00
HPX Commitd5655f89770ba953e8de3ceb349567d5fcb74a95723fce0a95b8b5e4deb97521f5d5b6763eddc9ce
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile
Hostnamenid01193nid01159
Datetime2022-05-31T15:13:01.357969+02:002022-08-10T20:26:22.517883+02:00
Clusternamedaintdaint

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
HPX Datetime2022-05-31T12:57:29+00:002022-08-10T18:11:09+00:00
HPX Commitd5655f89770ba953e8de3ceb349567d5fcb74a95723fce0a95b8b5e4deb97521f5d5b6763eddc9ce
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile
Hostnamenid01193nid01159
Datetime2022-05-31T15:13:18.026239+02:002022-08-10T20:26:39.667478+02:00
Clusternamedaintdaint

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2021-11-10T19:14:21+00:002022-08-10T18:11:09+00:00
HPX Commit71d8dbe40b737be02ea734f9d98fcc0b1e21f01a723fce0a95b8b5e4deb97521f5d5b6763eddc9ce
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile
Hostnamenid00120nid01159
Datetime2021-11-10T20:28:18.266961+01:002022-08-10T20:26:54.843070+02:00
Clusternamedaintdaint

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

StellarBot avatar Aug 10 '22 18:08 StellarBot

@hcq9102 things should be fine now. Please note that I also have rebased this branch onto master.

hkaiser avatar Aug 18 '22 17:08 hkaiser

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2022-05-31T12:57:29+00:002022-08-29T16:20:27+00:00
HPX Commitd5655f89770ba953e8de3ceb349567d5fcb74a954830586c0a05305994e4faf0b1f5cb5a45ba1650
Datetime2022-05-31T15:13:01.357969+02:002022-08-29T19:15:04.416369+02:00
Hostnamenid01193nid00013
Envfile
Clusternamedaintdaint
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
HPX Datetime2022-05-31T12:57:29+00:002022-08-29T16:20:27+00:00
HPX Commitd5655f89770ba953e8de3ceb349567d5fcb74a954830586c0a05305994e4faf0b1f5cb5a45ba1650
Datetime2022-05-31T15:13:18.026239+02:002022-08-29T19:15:21.732327+02:00
Hostnamenid01193nid00013
Envfile
Clusternamedaintdaint
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2021-11-10T19:14:21+00:002022-08-29T16:20:27+00:00
HPX Commit71d8dbe40b737be02ea734f9d98fcc0b1e21f01a4830586c0a05305994e4faf0b1f5cb5a45ba1650
Datetime2021-11-10T20:28:18.266961+01:002022-08-29T19:15:37.032623+02:00
Hostnamenid00120nid00013
Envfile
Clusternamedaintdaint
Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

StellarBot avatar Aug 29 '22 17:08 StellarBot

This can be closed as it is subsumed by #6015

hkaiser avatar Oct 05 '22 18:10 hkaiser

#6015 got merged. We don't need this one anymore.(sync_wait_with_variant integrating with sync_wait)

hcq9102 avatar Oct 05 '22 18:10 hcq9102