step icon indicating copy to clipboard operation
step copied to clipboard

Some books with one chapter are not viewable - eg Susanna, Bel, PrAzar.

Open DavidIB opened this issue 5 years ago • 0 comments

STEPBible originally couldn't view books with one chapter. This was fixed for those in the Protestant canon (Obadiah, Jude etc) but there is still a problem with books in the Apocrypha (Sus, Bel, PrAzar, AddPs - this last one isn't in KJVA). Strangely, the Prayer of Manasseh (PrMan) works fine. You can see the problem at https://www.stepbible.org/?q=version=KJVA|reference=Sus contrast this with a "Sus" as a second ref, when it works OK: https://www.stepbible.org/?q=version=KJVA|reference=Gen.1.1%20Sus

We want to add more Bibles with Apocrypha for Catholic users, so this bug will become more important.

I think that JSword had a problem with one-chapter books which was fixed in https://stepweb.atlassian.net/browse/TYNSTEP-394 But I guess that the problem was fixed for named books. This means that a search in the code for "Obadiah" or "Oba" might find it quickly.

David Haslam looked into this with regard to other JSword software and said: Have your programmers look for calls to BibleBook.isShortBook() and change it to v11n.getLastChapter(bibleBook) == 1. We need to eliminate isShortBook as it is hard coded and not based on the versification. Also, the BibleBook code for isShortBook is wrong for Prayer of Azariah (PrAzar), Susanna (Sus), and Bell and the Dragon (Bel). At least for the KJV. In the DC only Epistle of Jeremiah (EpJer) and Prayer of Manesses (PrMan) are marked as “short” books.

DavidIB avatar Mar 02 '21 10:03 DavidIB