dspot icon indicating copy to clipboard operation
dspot copied to clipboard

Feature: Amplifications location in report

Open sbihel opened this issue 6 years ago • 6 comments

During the amplification process, only the number of a-amplifications and i-amplifications is logged.

Do you think it is possible to also note the location of each amplification?

The location could be the line number, of the path in the AST. But I am not sure if it is possible because multiple rounds of amplifications can occur and we would then need to be able to keep the locations up-to-date.

sbihel avatar Mar 12 '18 15:03 sbihel

Yes, it is possible to track the position of I-amplification / A-amplification.

In DSpot, there this notion of test parent, i.e. the test on which is amplified to obtain new amplified test. The top parent, is the manual - original test. This relationship can be represented by a tree.

If we walk this tree, we can have all the amplifications applied.

I agree that would be great to have such information.

We started to this by adding some comment on the amplified tests. The problem is that the amplified test became unreadable, and so, comments are, by default, disable.

If we put this information into the json, which is possible I think we can completely remove comments.

danglotb avatar Mar 12 '18 16:03 danglotb

Ok I will work on this

sbihel avatar Mar 12 '18 17:03 sbihel

Okay, Great!

Do not hesitate to ask questions / suggest some stuff. I'll be glad to discuss!

I'm gonna change this issue into a track of your progress on this feature.

Cheers.

danglotb avatar Mar 12 '18 17:03 danglotb

Hi @sbihel

I think you won't gonna work on this anymore, right? I took the liberty to make it available.

danglotb avatar Dec 07 '18 22:12 danglotb

Hi @danglotb,

Yes sorry, I should have cleaned my mess 🙇‍♂️

sbihel avatar Dec 08 '18 10:12 sbihel

Hi @sbihel

It is totally fine! I'll just unassign you from this issue to highlight the fact that this is should be done.

I hope you are doing great, and I'll see around!

danglotb avatar Dec 08 '18 14:12 danglotb