PoGo-UWP
PoGo-UWP copied to clipboard
ST-Apps
Add Gyms
Changes:
- Adds Gyms to map (with no Icons)
Change details:
Gyms and the gym pages are on the map.
Other informations:
Icons Aren't showing click on where you know for a fact there is a gym and it will give information on the guard and etc
I think I accidentally uploaded some of my files to the branch for issue #1226
https://github.com/ST-Apps/PoGo-UWP/blob/master/PokemonGo-UWP/ViewModels/CapturePokemonPageViewModel.cs#L119-L122
and
https://github.com/ST-Apps/PoGo-UWP/blob/master/PokemonGo-UWP/ViewModels/CapturePokemonPageViewModel.cs#L146-L149
Excellent copy of my code! Hope it will be merged soon enough to prevent it from getting multiple conflicts. As was the case with my version (#908)
@mtaheij Yeah, speaking of you knowing it better than me. For some reason icons aren't showing on the map. can you fix that?
Don't know, I had it working, but I retracted my PR after it didn't get merged. I will try and make another PR tonight.
@ST-Apps This works well enough and the errors are will be fixed by someone else much faster. Please merge.
Cleaned. Not merging because it's just a visual change but gyms are still not working, so people will come here opening countless issues because they can't fight.
If you comment the code that shows them on the map I'll merge so that we can keep the code for later, but adding incomplete gyms will cause more harm than benefits.
@ST-Apps that can cause more people doing stuff this WHY CANT I FIGHT AND STUFF that is what it might say scince we know those people i use to get alot of them on my github before i had enough
I have a question and I think this is the place to ask it. The main reason for gym fighting is to obtain pokecoins, to be exact in 'store' there is an shield which is active once every 23 hours IIRC and when you click on the shield based on number of gyms in which you have pokemon (X) you get 50_X coins and 500_X stardust. What I'm asking is if there are even (not matter how far) plans of implementing such feature, since it deals with pokecoins which are real cash currency, or is it too risky and you're not planning to take that risk?
I'm new to the project and am trying to get my son involved in some dev stuff. What's holding us back from implementing full gym support? Limitation of the API, or have we just not got around to it yet?
We (at least I) do not know yet which requests (and what content they must hold) have to be sent in the request envelope to Niantic's servers, to open a gym battle and how to act on the responses they will send back. We also have to be very careful using accounts as invalid requests may cause a ban, and battles in gyms can only be done using accounts with level 5 and up.