PoGo-UWP icon indicating copy to clipboard operation
PoGo-UWP copied to clipboard

don't vibrate when phone vibrate is off

Open shamburg82 opened this issue 9 years ago • 11 comments

Device info:

  • Phone type: HTC one m8
  • App version: 1.0.25

Actual behavior:

When phone is on silent and vibrate is turned off, a nearby pokemon still vibrates the phone. I feel like this shouldn't happen when vibrate is off

Expected behavior:

Only vibrate when phone's set to vibrate.

Steps to reproduce the problem:

Other information:

Thanks!

shamburg82 avatar Aug 22 '16 11:08 shamburg82

Go to the app, tap the pokeball then settings. Choose vibrate off

DenisRraku avatar Aug 22 '16 12:08 DenisRraku

@DenisRraku I think he was meaning that if you silence vibration globally, the app shouldn't ignore that setting.

@shamburg82 This issue comes from the way the vibration gets triggered. It doesn't use the notification API for signaling pokemons. Same happens to the sound, which acts like standart music playback. @ST-Apps correct me if I checked this wrong.

Migsi avatar Aug 22 '16 13:08 Migsi

is a option in settings and it is easy to do so please close this @shamburg82

bluethefoxyt avatar Aug 22 '16 14:08 bluethefoxyt

I know its an option because I turned it on (default is off). But no one should have to go into options of every app every time I want to completely silence their phones when there is a global option for that built into the OS. Its just bad programming to bypass it.

shamburg82 avatar Aug 22 '16 14:08 shamburg82

I agree with samburg82, I do not have an Android phone but we should just copy their settings in this case. At the end, PoGo UWP is trying to follow the exact same behavior of the original Pokemon Go.

XIxJEALOUSxIX avatar Aug 22 '16 16:08 XIxJEALOUSxIX

Interfacing with the API shouldn't be too hard in my opinion, maybe a line or two that just checks what the system says it's set to, and then firing only if it's on.

fasterinnerlooper avatar Aug 22 '16 21:08 fasterinnerlooper

@sjetha AFAIK the API should just handle it itself, no need to check it at all, if it's done properly.

Migsi avatar Aug 22 '16 21:08 Migsi

To add to this I am getting vibrations for new Pokémon after completely closing the app so it seems like the notifications are getting stuck somewhere and keep firing.

BertchCA avatar Aug 23 '16 02:08 BertchCA

@herby40 are you sure you completely closed the app? I noticed with Windows 10 mobile that pressing the back arrow often times doesn't close the app like it did in windows phone 8/8.1. It only puts the app into standby.

(Don't get angry at me for not believing you, I am just making sure.)

sunkin351 avatar Aug 23 '16 20:08 sunkin351

@herby40 there are no notifications, if it vibrates it's because the app is still running.

ST-Apps avatar Aug 24 '16 09:08 ST-Apps

I will have to test it. But I doubt, that it will vibrate when the pogo settings vibration is ON and global phone vibration is OFF.

jakubsuchybio avatar Sep 16 '16 18:09 jakubsuchybio