adiar icon indicating copy to clipboard operation
adiar copied to clipboard

Rename `label` to `level`

Open SSoelvsten opened this issue 2 years ago • 2 comments

Currently, Adiar only uses the identity variable ordering, i.e. where xi has level i and so on. To support variable ordering without making the code incomprehensible, we need to replace label with level where appropriate.

  • [ ] ptr / uid
  • [ ] node
  • [ ] all request structs?

SSoelvsten avatar Oct 27 '22 12:10 SSoelvsten

Currently, I have given it to the deprecation label, but question is whether some parts of the public API will end up with a breaking change? It might be a good idea to already do this as part of #397 for v2.0 rather than v2.1 .

SSoelvsten avatar Oct 27 '22 12:10 SSoelvsten

One may also consider, whether nodes should only know the label and not the level. Whenever a request is made, the label is translated into its level to still get the queue to work. The positive side-effects of this is, that this may allow one to do the swapping operation when combined with #154 .

SSoelvsten avatar Nov 24 '22 19:11 SSoelvsten