rust-objc icon indicating copy to clipboard operation
rust-objc copied to clipboard

Run rustfmt and require it in CI

Open madsmtm opened this issue 3 years ago • 2 comments

The changes I've made can be seen here - the rest is done automatically by rustfmt

madsmtm avatar May 27 '21 13:05 madsmtm

I'll be honest, I think rustfmt does some ugly things, so I'm not in any rush to do this. If there's a lot of changes being merged from multiple contributors, I think this makes sense. But as you can see that's not the case here because I am neglectful. I will keep this in mind to merge if development ramps back up here.

SSheldon avatar Aug 04 '21 04:08 SSheldon

I agree that it's formatting is suboptimal, but it's better than nothing, and some things it definitely does better (like putting the explicit "C" on extern items, considering the maybe upcoming "C-unwind").

Which parts is it specifically that you have a gripe with? rustfmt's behaviour can easily be changed to suit your preferred style, see this.

But yeah, no rush on this one.

madsmtm avatar Aug 06 '21 20:08 madsmtm