Results 56 comments of SSebo

Test case is stable now by checking `Open` and `Close` callback.

@nshaaban-cPacket looks like not review the latest code? I force pushed code 3 days ago.

> solution three: rename ReconnctingClient to Client (and take it's place), and rename existing client to InternalClient @nshaaban-cPacket I tried, found that InternalClient is hard to hide from user because...

@1c3t3a Compiler does not complain until I create a trait object `Box`: --> socketio/src/client/reconnect.rs:40:8 | 14 | pub trait ClientTrait { | ----------- this trait cannot be made into an...

> > @1c3t3a Compiler does not complain until I create a trait object `Box`: > > --> socketio/src/client/reconnect.rs:40:8 | 14 | pub trait ClientTrait { | ----------- this trait cannot...

> I've been testing this for a while now and it works great. I did notice that reconnects don't happen when losing internet connection, it just simply does nothing and...

@1c3t3a @nshaaban-cPacket PTAL

@JackFlukinger I found the callback not `await`, so not really executed. @1c3t3a I made a PR #226 https://github.com/SSebo/rust-socketio/blob/78f07ded196e3b6d5b2209ba0fafc86a0f3d0b15/socketio/src/asynchronous/client/client.rs#L232

hi, @1c3t3a : > The fact that the callback takes a `Client` as an argument is the root of the whole "client-needs-to-be-clonable" problem https://github.com/SSebo/rust-socketio/blob/0b1890e5f7036105ef6661c4be7656af43f0ef16/socketio/src/client/client.rs#L37-L54 For reconnecting, the Client is cloneable,...

> EDIT: Something else I noticed it that I don't receive events from the server anymore after some time. the thread which is respond to handle packet to callback is...