UEGitPlugin icon indicating copy to clipboard operation
UEGitPlugin copied to clipboard

Verbose logging enabled in RunCommandInternalRaw

Open ccarvalheiro opened this issue 5 years ago • 3 comments

In a recent commit, the logging in RunCommandInternalRaw was enabled by commenting #if UE_BUILD_DEBUG. See here and here.

Was this change made intentionally? ~~It appears to slows down our mid sized projects and~~ (Disregard this since it shouldn't have any significant impact on performance) Sometimes floods the log making it difficult to use.

ccarvalheiro avatar Jun 14 '19 21:06 ccarvalheiro

Yes, it's intentional since I received bug reports when I have only the logs to try to understand what's going on.

Sorry for the inconvenience, the idea would be to add a setting to have this optional.

SRombauts avatar Oct 30 '19 06:10 SRombauts

Oh, that makes sense. I can help with that. Should we add a checkbox to the source control dialog or hide it away in project settings (in the plugin settings category)?

ccarvalheiro avatar Nov 03 '19 23:11 ccarvalheiro

Hello, until now I have always put everything on the source control dialog.

Perhaps should we also be able to find some of these settings also in the project settings? I never thought about it but I am pretty sure it would help people find them.

Cheers!

SRombauts avatar Nov 05 '19 10:11 SRombauts