SQLiteCpp icon indicating copy to clipboard operation
SQLiteCpp copied to clipboard
verified publisher icon SRombauts

fix: update the c++ version selection process

Open SGSSGene opened this issue 7 months ago • 3 comments

The c++ version should be set via target_compile_features(SQLiteCpp PUBLIC cxx_std_11) This only sets this as a minimum version for this target, and not all targets.

SGSSGene avatar May 23 '25 18:05 SGSSGene

Hey @SGSSGene, that sounds like a nice improvement as well, thanks for taking the time to provide the PR!

SRombauts avatar May 27 '25 07:05 SRombauts

@SRombauts: All changes that we currently do downstream in the OpenMS project :-)

What CMake version is suitable? This is also why I asked here, what the current supported platforms are https://github.com/SRombauts/SQLiteCpp/issues/510 I would like to bump the CMake version up, as far possible.

SGSSGene avatar May 27 '25 13:05 SGSSGene

I would like to bump the CMake version up, as far possible. My strategy up to know regarding supported platforms has always be to try to keep it backward compatible as long as possible. Her for instance I would just update from 3.5 to 3.8.

Then, if you have any other pull request with more changes requiring another bump, I would evaluate that again. But if you have any specific version in mind with a good reason I am happy to consider it instead.

SRombauts avatar May 31 '25 14:05 SRombauts