SQLiteCpp icon indicating copy to clipboard operation
SQLiteCpp copied to clipboard

Explicitly =delete; Statement::bindNoCopy(..., std::string&&)

Open maysl opened this issue 1 year ago • 1 comments

Rvalues are inherently unsuitable for no-copy binding, because their lifetime cannot be guaranteed. Separately declare, and delete, all overloads of bindNoCopy() that take a std::string rvalue.

maysl avatar Jun 18 '24 17:06 maysl

Hi @SRombauts,

We ran into the issue that in a long sequence of legitimate bindNoCopy() calls, there was one that used a std::to_string() as its value. This sort of mistake can easily happen, but it's equally easy to mitigate. Hence the PR.

Thank You for your work!

maysl avatar Jun 21 '24 09:06 maysl

seems that the CI issue in macos is caused due to PEP 668, I will make a PR to fix the issue

UnixY2K avatar Aug 14 '24 05:08 UnixY2K

created #476 to fix the macOS CI issue

UnixY2K avatar Aug 14 '24 05:08 UnixY2K

Thanks a lot for your contribution. Sébastien

SRombauts avatar Aug 15 '24 17:08 SRombauts