SQLiteCpp icon indicating copy to clipboard operation
SQLiteCpp copied to clipboard

Improved efficiency and code reuse with templates and pure functions

Open KOLANICH opened this issue 6 years ago • 3 comments

KOLANICH avatar Dec 24 '19 16:12 KOLANICH

Hello, thanks again for this new series of pull requests. Have you seen that they have all failed CI?

SRombauts avatar Dec 24 '19 20:12 SRombauts

Hello, thanks again for this new series of pull requests.

Not quite new, just splitted the old #182 into multiple PRs.

no template named 'enable_if' in namespace 'std' error: ‘enable_if’ in namespace ‘std’ does not name a template type

Old versions of C++ should be dropped.

KOLANICH avatar Dec 24 '19 22:12 KOLANICH

@KOLANICH I find your PR very valuable but I think it may be easier to digest if split into again smaller parts.

@SRombauts What is your take on the points raised by KOLANICH? Lets take one aspect out, templates. Would you agree that adding stronger use of templates is a good thing? I recently had to fix something about the types in Statement::bind(), and I found what KOLANICH also found, that these methods are quite lengthy code for a thing that would become much shorter and cleaner with templates.

Would you accept a PR that adds stronger use of templates (for better code reuse and shortening of the existing code)?

emmenlau avatar Nov 27 '20 21:11 emmenlau