SRSaunders
SRSaunders
shader_debugprintf: support new VVL-DEBUG-PRINTF message and fix VVL version check for API selection
Thanks @asuessenbach for pointing out the missing `VK_EXT_validation_features` extension. I have made a few changes that might make a difference as follows: 1. Moved layer settings out of the constructor,...
shader_debugprintf: support new VVL-DEBUG-PRINTF message and fix VVL version check for API selection
Ok, I think I have finally figured it out. It appears that you _don't_ need to actually enable the `VK_EXT_layer_settings` extension in order to use it. I’m not sure if...
shader_debugprintf: support new VVL-DEBUG-PRINTF message and fix VVL version check for API selection
Thanks @asuessenbach for the info re nVidia GPUs. I have an AMD card and I guess this is the difference here. @SaschaWillems would you please test using this PR with...
shader_debugprintf: support new VVL-DEBUG-PRINTF message and fix VVL version check for API selection
@SaschaWillems I understand. However I’d still like to track this down if possible and you testing on Nvidia with vkconfig active would give more information. I can’t do this test...
shader_debugprintf: support new VVL-DEBUG-PRINTF message and fix VVL version check for API selection
I just added a minor hygiene change to use `vk::ExtensionProperties` vs. `VkExtensionProperties` in **HPPInstance()**. Also updated some comments and decided to explicitly request required GPU features for **debugPrintfEXT** as per...
shader_debugprintf: support new VVL-DEBUG-PRINTF message and fix VVL version check for API selection
When using an nVidia GPU with SDK 1.3.296, it slows down for all API versions. When using SDK 1.3.290 with the same setup (nVidia GPU), the sample works properly when...
shader_debugprintf: support new VVL-DEBUG-PRINTF message and fix VVL version check for API selection
> I tried to update the VVL docs for it https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/main/docs/debug_printf.md @spencer-lunarg thanks for updating the docs. This is the same doc I referred back to today when digging into...
shader_debugprintf: support new VVL-DEBUG-PRINTF message and fix VVL version check for API selection
@spencer-lunarg I have raised issue https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/8760 as requested. > so basically this PR is not fix/breaking things from my end... I agree this seems like something on the VVL side...
shader_debugprintf: support new VVL-DEBUG-PRINTF message and fix VVL version check for API selection
Following interaction with the VVL team, I think this is now ready for review. A couple of learnings: 1. The `VK_EXT_layer_settings` extension is trickier than I first realized. On Windows...
shader_debugprintf: support new VVL-DEBUG-PRINTF message and fix VVL version check for API selection
> > It turns out that while the VVL debugPrintfEXT feature requires this and implicitly enables it under the covers, explicitly requesting support in the sample breaks performance. > >...