SR5-FoundryVTT icon indicating copy to clipboard operation
SR5-FoundryVTT copied to clipboard

[BUG] Navigation Is Lost in Active Effects Skill Selector

Open tjlanza opened this issue 1 year ago • 2 comments

Describe the bug "Navigation" does not appear correctly in the list of available skills, and cannot be picked. Typing it in an hitting enter works, and it appears to function normally, but it doesn't look right and can't be deleted.

Damnit, Navigation! You're the one we depend on to know where we are!

Modules Absolutely none, not even the recommend/compatible ones.

To Reproduce Steps to reproduce the behavior are shown via screenshot.

Screenshots Looks strange... image

image

image

...works fine. image

Versions (please complete the following information):

  • FoundryVTT v11.315
  • SR5 v0.18.4

tjlanza avatar Jan 11 '24 16:01 tjlanza

Haven't got a clue why that would be the case :D

I put this at a low prio bug.

taMiF avatar Jan 13 '24 10:01 taMiF

The issue stems from tagify using id="navigation" as a data identifier, while it's also a CSS id field.

This clashes with the FoundryVTT navigation bar on top, also using id="navigation". This breaks CSS and JavaScript selectors of tagify both... While we could fix CSS issue by using 'all: unset' and hackily rebuilding tagify CSS, we can't do so easily for the JavaScript selectors breaking (selecting / unselecting navigation via mouse)

I assume tagify doesn't normally use id as a data identifier but the system causes it to do so, due to some inproper use of id and value during creation of the different tagify elements. So some time needs to be invested to look into different ways of setting up tagify...

taMiF avatar Mar 24 '24 11:03 taMiF