HVScrollView icon indicating copy to clipboard operation
HVScrollView copied to clipboard

如果某个分类的tableView数据为空,可以让他也可以往上滑动并且悬浮么

Open H2OB opened this issue 5 years ago • 0 comments

因为其他的分类如果有数据,某个页面没有数据,你继续滑动,就会很突兀的滑动下来

H2OB avatar Jan 20 '19 13:01 H2OB

Replaced the std::cout statements with exceptions, because a library shouldn't display any error messages.

Please note this is a highly subjective statement, about which many people will disagree for various reasons.

In order to stay with the current "philosophy" of this project (boolean returns, logging of errors), what could be done instead to increase flexibility is to use an output stream for the error messages that can centrally redirected.


On another note, you changed all the indents and operator spacings in your commit which, for one, makes it extremely difficult to review. Also, I believe the etiquette is usually to adjust your coding style to the existing project, not the other way around.

Sidelobe avatar Jul 22 '19 12:07 Sidelobe

you changed all the indents and operator spacings in your commit which, for one, makes it extremely difficult to review. Also, I believe the etiquette is usually to adjust your coding style to the existing project, not the other way around.

Apologies, I copied and pasted the entire file, with my modifications, from Visual Studio into GitHub. For future reference, how do I copy and paste only the changes I made?

edwardkarak avatar Jul 22 '19 18:07 edwardkarak

For future reference, how do I copy and paste only the changes I made?

Hmm, that's a tough one... no easy answer for that one. In principle I would carefully review my changes 1 by 1 with my Git client or a diff tool and make sure I commit only the changes I want/ought to.

You could also adjust your editor (temporarily?) to match the coding conventions used in the project (indent, operator spacing, bracing, etc...), but then you would have to fiddle with the settings until you match the style (tedious).

Your best best is probably to try and disable any auto-formatting in your editor and never, ever run a 'prettify' or 'format code' and then carefully review your changes before committing.

Sidelobe avatar Jul 23 '19 07:07 Sidelobe

I've now updated the library so that the logging of error messages to the console is optional. By default they are logged, but you can call..

audioFile.shouldLogErrorsToConsole (false);

to switch it off if you don't want that. This is on the develop branch now,

Adam

adamstark avatar Feb 28 '20 23:02 adamstark