sparql.anything
sparql.anything copied to clipboard
IT tests failing after executor refactoring
As the summary says
Apparently, after using the ondisk option, subsequent tests are failing. I isolated testIssue280
and testIssue284
. 284 runs smoothly if executed alone. The test class we are focusing on now is IssuesTest2
the BaseFacadeXGraphBuilder uses static fields https://github.com/SPARQL-Anything/sparql.anything/blob/70c402a7093a8b7d82b6840323f6cc6422122201/sparql-anything-model/src/main/java/com/github/sparqlanything/model/BaseFacadeXGraphBuilder.java#L42
maybe the problem depends on this?
This https://github.com/SPARQL-Anything/sparql.anything/blob/70c402a7093a8b7d82b6840323f6cc6422122201/sparql-anything-model/src/main/java/com/github/sparqlanything/model/BaseFacadeXGraphBuilder.java#L58 Shouldn't it be !BaseFacadeXGraphBuilder.previousTDB2Path.equals("")?
This 8c6de26 removes the static fields from the class BaseFxGraphBuilder. Tests in IssuesTest2 don't fail anymore
We can close this issue if there are no other tests failing.
I close this issue as it is completed via f1355c0