SORMAS-Project
SORMAS-Project copied to clipboard
SORMAS-Foundation
Feature/epic 12881 self reset password
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13096
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13096
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13096
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13096
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13096
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13096
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13096
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13096
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13096
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13096
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13096
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13096
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13096
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13096
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13096
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13096
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13096
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13096
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13096
This feature is not working as expected when the authentication provider is keyclock, as the password changed triggers a password reset the next time you log in with the user and this password is not recognized by the feature when you try to change your password again you will get current password incorrect error.
This feature is not working as expected when the authentication provider is keyclock, as the password changed triggers a password reset the next time you log in with the user and this password is not recognized by the feature when you try to change your password again you will get current password incorrect error.
We did not factor in the use case of authentication provider = keycloak, but now you have spoken about it we will add that. Thanks
Unable to review because the code formatting is changed so a lot of existing code looks to be changed. Please set up the code formatting in your IDE as described in the docs https://github.com/SORMAS-Foundation/SORMAS-Project/blob/development/docs/DEVELOPMENT_ENVIRONMENT.md#step-6-configure-code-formatting-and-import-settings, and reformat all the changed code.
I have done that already but it seems because i previously worked on some classes and reverted those changes after the push, github is tracking them as changes but i will ..still look at it again with Obinna by tomorrow. Thanks
The easiest would be:
- The button to reset password should be hidden, when keycloak is used as authentication provider.
If you want to have a more sophisticated approach:
- Add a feature configuration for "Self reset password"
- If Keycloak is the authentication provider the button should redirect the user to the "forgot password"-flow, which does actually the same as resetting the password.
The feature configuration should - be default - be false. If SORMAS admins want/need that functionality they can just enable it in the feature config
The easiest would be:
- The button to reset password should be hidden, when keycloak is used as authentication provider.
If you want to have a more sophisticated approach:
- Add a feature configuration for "Self reset password"
- If Keycloak is the authentication provider the button should redirect the user to the "forgot password"-flow, which does actually the same as resetting the password.
The feature configuration should - be default - be false. If SORMAS admins want/need that functionality they can just enable it in the feature config
All right.