SORMAS-Project icon indicating copy to clipboard operation
SORMAS-Project copied to clipboard

[Configuration - Outbreaks] Error message appears in the 'Configuration' directory if outbreaks exist for disabled diseases

Open adinaflorea9 opened this issue 2 years ago • 2 comments

Bug Description

When entering the 'Configuration' directory, an error message is displayed if outbreaks exist for diseases which have been disabled in the meantime.

Steps to Reproduce

  1. Log in with an Admin+National User and create outbreaks for a few diseases (AFP and Cholera);
  2. In the Data Base, open the 'diseaseconfiguration' table and disable AFP and Cholera (set to 'False': 'primarydiseaae', 'casesurveillanceenabled' and 'aggregatereportingenabled');
  3. Save the changes and restart the server;
  4. Log back in the app with the same Admin+National User and click on the 'Configuration' directory.

Actual Behavior

An error message is displayed and only 1 tab of the directory is visible: image

Expected Behavior

No error message should be displayed; all tabs of the directory should be visible.

In regards to the outbreaks that were created and whose diseases have been disabled, @MateStrysewske and/or @MartinWahnschaffe could you please take a look and specify the expected behavior:

  • should the diseases still be listed and the outbreaks visible?
  • should the diseases not be listed (as the behavior currently is) and the outbreaks not be visible?

Screenshots

System Details

  • Device: Windows 10
  • SORMAS version: 1.76.0-SNAPSHOT(a9b2e5b) - could not determine whether this is reproducible on earlier versions or not as I do not have access to the DB of testing instances in order to disable the diseases
  • Android version/Browser: Chrome
  • Server URL: local machine
  • User Role: Admin+NatUser

Additional Information

Logs from the local machine: outbreaks.txt

adinaflorea9 avatar Sep 19 '22 13:09 adinaflorea9

@MartinWahnschaffe I would just ignore diseases that are inactive in this view, i.e. make sure that outbreaks retrieved from the backend for these diseases are not processed any further. What's your take on this?

MateStrysewske avatar Sep 21 '22 08:09 MateStrysewske

Agreed. I'd also simply ignore those outbreaks.

MartinWahnschaffe avatar Sep 21 '22 10:09 MartinWahnschaffe

Updated the expected behavior according to the comments from above.

adinaflorea9 avatar Sep 22 '22 12:09 adinaflorea9

Verified ticket on local setup using the latest version of Sormas 1.76.0-SNAPSHOT (a4749d0).

roxanamlendea avatar Oct 10 '22 15:10 roxanamlendea