soci icon indicating copy to clipboard operation
soci copied to clipboard

File "private/soci-trivial-blob-backend.h" missing

Open Spixmaster opened this issue 1 year ago • 4 comments

@Krzmbrzl, the commit #992 includes #include <private/soci-trivial-blob-backend.h> which is not present when installed with CMake.

Spixmaster avatar Jun 07 '24 13:06 Spixmaster

See my revamp cmake PR. I think there this should be fixed

Krzmbrzl avatar Jun 07 '24 17:06 Krzmbrzl

#1118 for reference.

Spixmaster avatar Jun 07 '24 18:06 Spixmaster

Private headers are not supposed to be installed, so if this header is used by the public headers, it can't be private.

I.e. it's not (just) a build system problem, it's a problem with the header name/path.

vadz avatar Jun 08 '24 11:06 vadz

The header is used two times, here and here.

Spixmaster avatar Jun 08 '24 11:06 Spixmaster

I had another look at this and am now in line with what @vadz said. That is, I misused private headers. Consequently, this is fixed in #1165

Krzmbrzl avatar Aug 31 '24 14:08 Krzmbrzl