soci icon indicating copy to clipboard operation
soci copied to clipboard

Revamp CMake support

Open Krzmbrzl opened this issue 2 years ago • 10 comments

Fixes #1115 Fixes #1152 Fixes #1122 Fixes #1094

Krzmbrzl avatar Jan 03 '24 16:01 Krzmbrzl

Do you think we should wait for this before making SOCI 4.1.0 release or can we leave this change until a later 4.1.x?

vadz avatar Jan 11 '24 14:01 vadz

Do you think we should wait for this before making SOCI 4.1.0 release or can we leave this change until a later 4.1.x?

Well, it would probably be nice if 4.1 had this already, but it's more of a nice-to-have. So I guess you don't have to wait for this PR to be done. However, my planned timeline for this PR is to get this finished within the next two to three weeks. Depending on your plans for 4.1, waiting for such a time period would be okay? But as I said: it's optional.


Unrelated to this PR, I would appreciate if #992 made it into 4.1 though :)

Krzmbrzl avatar Jan 13 '24 19:01 Krzmbrzl

@vadz This pull request is probably needed for 4.1 to work. See #1153.

Spixmaster avatar Jun 07 '24 18:06 Spixmaster

As I wrote in #1153, the header really should be renamed/moved, so it's not directly related to this PR, but please let me know when this one will be ready for review in any case. Thanks!

vadz avatar Jun 08 '24 11:06 vadz