sumo icon indicating copy to clipboard operation
sumo copied to clipboard

Colours in DOS

Open brlec opened this issue 2 years ago • 3 comments

Hi guys, Would it be possible to either remove the defaults in sumo/plotting/orbital_colours.conf or change them so that O, S and Se aren't all the same green for the p orbitals? Very minor but it's really annoying to have to make the conf files when you just want to quickly check a DOS Thanks!

brlec avatar May 23 '23 13:05 brlec

Sure, submit a PR. Happy for you to remove them from the config.

utf avatar May 23 '23 13:05 utf

think it worked?

brlec avatar May 23 '23 14:05 brlec

Hmm, I thought I'd posted a comment here already! Maybe I got distracted before it was done, that happens at lot at the moment...

This change will probably cause unpleasant surprises for some users who don't expect their plotting colour scheme to change! If the current problems are:

  • it is a nuisance to set colours in the directory or to explicitly pass a config file, when the user has a simple and consistent preference
  • there is no way to disable the default colours

Then I suggest a "non-destructive" alternative that could solve both problems:

  • look for a user config file somewhere like ~/.config/sumo/dos-colors.conf
  • The priority order is --conf > user config > defaults
  • An empty (but existing) user file will override any default colours; if users want to tweak the stock colours they should start with a copy of the defaults

ajjackson avatar May 29 '23 21:05 ajjackson