Test for pbs files on slurm

[aalitaiga]

[bouthilx]

@aalitaiga You should rename pbs_slurm_test.py otherwise Travis will keep reporting failures. We could add --ignore-files= in .travis.yml but we don't want those tests to run locally neither. They are only usefull if we want to tests new settings on the slurm configuration, so they should only be ran alone. A name like verify_slurms_pbs_wrapper.py would be self-explanatory.

[bouthilx]

We need unit-tests for

• [x] add_sbatch_flags
• [x] add_sbatch_options
• [x] ~~command line option~~
• [x] job generator pbs file replacements (pnn, gpus, etc)

Make sure to test that what should pass, pass and what should fail fails. We need to try many different things to test the command line options. For instance, we need to try adding bad options or adding options already included by job generator. We need to make sure to test every cracks as this seems to me as an error-prone setup (replacing options for a framework by options a wrapper of another framework will recognize as what we want it to be for the latter framework :sweat:).

[coveralls]

Coverage increased (+0.8%) to 95.346% when pulling a02e32b074c1e0e8595fe9a725fac0eb21683ba0 on aalitaiga:adrien_slurm into 9133e15ae91e1e5b0a2b7e90f442c1ebfb623e86 on SMART-Lab:master.

[coveralls]

Coverage increased (+0.8%) to 95.346% when pulling 39107f1b71e7041a156dd5ca5bb0d15f224d0ffe on aalitaiga:adrien_slurm into 9133e15ae91e1e5b0a2b7e90f442c1ebfb623e86 on SMART-Lab:master.

[coveralls]

Coverage increased (+1.2%) to 95.725% when pulling 998f3ba6efe986f9cd641c2c807266cac28fa13c on aalitaiga:adrien_slurm into 9133e15ae91e1e5b0a2b7e90f442c1ebfb623e86 on SMART-Lab:master.

[coveralls]

Coverage increased (+1.2%) to 95.725% when pulling a3c08c867b532969a7639115d13903bdfc3007c6 on aalitaiga:adrien_slurm into 9133e15ae91e1e5b0a2b7e90f442c1ebfb623e86 on SMART-Lab:master.

[coveralls]

Coverage increased (+1.2%) to 95.725% when pulling 9fb5ab66a7c4ff6c3df067b92ff00d4f8b27fcac on aalitaiga:adrien_slurm into 9133e15ae91e1e5b0a2b7e90f442c1ebfb623e86 on SMART-Lab:master.

[coveralls]

Coverage increased (+1.2%) to 95.738% when pulling 1dea0d8288d898f8c8997379f2fa3606d1457aad on aalitaiga:adrien_slurm into 9133e15ae91e1e5b0a2b7e90f442c1ebfb623e86 on SMART-Lab:master.

[coveralls]

Coverage increased (+1.2%) to 95.738% when pulling 33c048bdd9d0c124127b7893a65f52c6b95c723b on aalitaiga:adrien_slurm into 9133e15ae91e1e5b0a2b7e90f442c1ebfb623e86 on SMART-Lab:master.