FSCT icon indicating copy to clipboard operation
FSCT copied to clipboard

Published 20 hours ago • verified publisher icon SKrisanski

Dockerized FSCT project

Open smorcuend opened this issue 2 years ago • 4 comments

Main changes:

  • Main file added to invoke code from project root path. Python arguments refactored.
  • Unused imports removed
  • FSCT main configuration moved to specific configuration files (config.ini)
  • Dockerized code with entrypoint to invoke executions from host

smorcuend avatar May 24 '22 15:05 smorcuend

This looks great! Apologies for the slow reply. Thank you for your contribution. I was thinking about dockerising it myself only a few weeks ago. I just need to do some testing myself before merging, but I'll aim to do that within a few weeks. Thanks again, Sean

SKrisanski avatar Jun 04 '22 05:06 SKrisanski

Hi @SKrisanski. Maybe this PR is very large, i noticed. I think could make piece of code more smaller.

smorcuend avatar Jun 22 '22 12:06 smorcuend

Hi Sergio,

Sorry I haven't got to it yet. No need to make it smaller, I'm just a bit short on time currently (I've been away from home for the last few weeks for work), so haven't had time to go through it thoroughly yet.

Thanks again for the PR. I'll try to go through it soon. Sean

SKrisanski avatar Jun 22 '22 12:06 SKrisanski

Hi @SKrisanski ,

Any updates on the possibility of merging the dockerization changes to master?

tariqislam avatar Sep 14 '24 05:09 tariqislam