Launcher icon indicating copy to clipboard operation
Launcher copied to clipboard

Enhancement Allow building packs without having the original jar

Open kayila opened this issue 9 years ago • 6 comments

Some mods prohibit the re-hosting of their jar file in any form, but allow themselves to be included in mod packs. Now this isn't a problem, depending on how the pack is maintained and built in that when it is deployed to a server, any jar which has a .url.txt file associated with it is not included in the uploaded files. If, however, the pack is stored in it's unpackaged state, such as in github for multiple people to work on the pack or an automated system to assemble it, we currently have to upload the .jar to that site. I understand that the reason we need the .jar is for building the checksum. It would be nice if I could provide a checksum to use so the pack could be stored (For example maybe a mod.jar.md5 file) without having to store the actual .jar.

The creator tools and server build tools would need to be modified to download the mod when either testing or when building the server kit, but this would allow the complete lack of mod .jar files being stored in revision control and the like.

kayila avatar Feb 16 '16 20:02 kayila

I know this isn't a fix from the launcher stand point but there are two ways to solve this in my experience.

  1. You could host the jars in a private repo, and have the configs in a public repo linked via a submodule. BitBucket and GitLab allow for free private repos.
  2. You could use a modpack downloader of sorts to download the mods and only store the code that links to those mods. Kinda like how the Curse launcher has a manifest.json file that points to all of the mods needed for that pack.

Nincodedo avatar Feb 16 '16 21:02 Nincodedo

Offtopic question: Do you know of any way to treat Github like a web repository, and get direct links for every file in the repo?

ajthemacboy avatar Feb 16 '16 21:02 ajthemacboy

@ajthemacboy go to the file in the repo and click Raw on the top right. You'll get a link like this https://raw.githubusercontent.com/Nincodedo/Nincrafty-Things/master/README.md

Nincodedo avatar Feb 16 '16 21:02 Nincodedo

@Nincodedo I know that much; it's hard to explain what I mean. I'll try to gather my words.. :)

ajthemacboy avatar Feb 16 '16 22:02 ajthemacboy

@ajthemacboy Did you mean something more like this? https://github.com/Nincodedo/nincraft.com/tree/gh-pages

Nincodedo avatar Feb 16 '16 22:02 Nincodedo

I could possibly have it pull an hash of the file at the URL as well.

However, there might need to be a .jar cache to make the test function work better, because hitting the URL every time a modpack is tested would be brutal.

sk89q avatar Feb 18 '16 07:02 sk89q