sipp icon indicating copy to clipboard operation
sipp copied to clipboard

Add a log when sipp scenario ends due to rtp or echo errors

Open smititelu opened this issue 3 years ago • 3 comments

Previously, when got some rtp/echo errors, sipp returned a failure code upon successful completion of xml scenario.

Now it returns success if xml scenario completes, and just logs rtp errors.

related to #569

smititelu avatar Dec 06 '22 08:12 smititelu

Let's see if I understood correctly:

If an SIPp xml scenario completes successfully from SIP point of view, but it had rtp errors, it should return (EXIT_TEST_OK|EXIT_RTPCHECK_FAILED)...

... and then, on OS side, check the return code of last ran (sipp) command and take out the EXIT_RTPCHECK_FAILED (e.g. $? & ~EXIT_RTPCHECK_FAILED) ?

If that is the case, I don't agree with it. Because an end user will see sipp scenario complete ok but "$?" OS var will be != 0. So basically, sipp scenario failed, even if you see it completing successfully. That would be misleading, imho. Logging an warning but still succeeding would be more clear, imho.

smititelu avatar Dec 07 '22 13:12 smititelu

Updated PR to just log when scenario ends due to rtp/echo errors.

smititelu avatar Dec 07 '22 14:12 smititelu

Updated log to warning

smititelu avatar Dec 08 '22 09:12 smititelu