pysipp icon indicating copy to clipboard operation
pysipp copied to clipboard

FEAT: Added support for -nd flag.

Open iikercosta opened this issue 3 years ago • 3 comments

SIPp v3.6.1 supports the flag -nd but this project does not. With this commit pysipp supports the -nd flag through the keyword param no_default.

-nd              : No Default. Disable all default behavior of SIPp which are the following:
                      - On UDP retransmission timeout, abort the call by sending a BYE or a CANCEL
                      - On receive timeout with no ontimeout attribute, abort the call by sending
                        a BYE or a CANCEL
                      - On unexpected BYE send a 200 OK and close the call
                      - On unexpected CANCEL send a 200 OK and close the call
                      - On unexpected PING send a 200 OK and continue the call
                      - On any other unexpected message, abort the call by sending a BYE or a
                        CANCEL

iikercosta avatar Sep 23 '22 09:09 iikercosta

An example of use for using this extra argument could be the following pysipp.client(destaddr=('10.10.8.88', 5060), no_default=True)()

iikercosta avatar Sep 23 '22 12:09 iikercosta

@iikercosta iikercosta, apologies for this sitting so long.

It looks good to me but not sure if any additional test helps here; i'm thinking no since it'd just be testing our kwargs -> cli flags machinery?

Can you rebase this to latest master so we can see CI run as well?

goodboy avatar Dec 18 '22 19:12 goodboy

Yeah, only affects cli arguments. Already merged the lastest master

iikercosta avatar Dec 29 '22 18:12 iikercosta