leaflet 1.0 compatibility?

[denjello]

Just wondering if this is on your to do list.

[simison]

+1

http://leafletjs.com/2015/07/15/leaflet-1.0-beta1-released.html

The release sports a number of minor breaking API changes, and some of the plugins will have to be updated. To make the upgrade less painful, we’re doing a short beta cycle before the final 1.0 to allow users and plugin developers to catch up to the changes while we find and fix remaining issues.

:-)

[fungiboletus]

Yes, Leaflet 1.0 must be supported.

However the European project supporting this plug-in has ended last month. I will probably look into it during my spare time but I can't promise anything.

I used Leaflet's development branch with PruneCluster in the beginning of the year and it was working. I hope the recent changes will not break it :-)

[simison]

Perhaps you could ask around at https://groups.google.com/forum/#!forum/leaflet-js or https://gitter.im/Leaflet/Leaflet if someone would be willing to help maintain this together.

This plugin is just too awesome to let it fade away. :-)

I used Leaflet's development branch with PruneCluster in the beginning of the year and it was working.

Great!

[denjello]

I am running a test on it right now, and it appears to be working fine with:

"leaflet": "~1.0.0-beta.1"
"PruneCluster": "SINTEF-9012/PruneCluster#~1.1.0"

But I guess there should probably be some rigorous testing.

[simison]

I searched the codebase quickly for 1.0-beta1 breaking changes https://github.com/Leaflet/Leaflet/blob/master/CHANGELOG.md#other-breaking-api-changes

And I can see only DomUtil off being used, which has breaking changes (dunno if this affects PruneCluster though):

Changed DomUtil off to require context attribute if you remove a listener that was previously added with a particular context.

[fungiboletus]

This plugin is just too awesome to let it fade away. :-)

I hope we will get a new project using this plugin so we can improve it :-) I don't want to let it fade away but I also do a lot of development at work these days and I just want to relax during my spare time.

I will test a bit Leaflet 1.0, but it's good to see that it already works :-)

Moreover after watching Vladimir's talk about the simplicity in leaflet (https://www.youtube.com/watch?v=NLbyHffKQuU), I think PruneCluster's API is not simple enough and doesn't fit well with Leaflet. I will first make PruneCluster compatible with Leaflet 1.0, but this major release is maybe a good opportunity to develop the new API.

[simison]

Cool. BTW we're using this here; https://www.trustroots.org / https://github.com/trustroots/trustroots

It's coupled with ~~https://github.com/tombatossals/angular-leaflet-directive~~ https://github.com/angular-ui/ui-leaflet and the controller running that map is going to get much more complex in the future, so I will probably work more on getting this tight closer into Angular-Leaflet if possible.

[denjello]

@simison → I tried out tombatossals directive, but as soon as I had hundreds of markers I needed to switch to prunecluster instead of native markercluster - for glaringly obvious performance reasons, Unfortunately, as hard as I tried I couldn't integrate prunecluster with the angular-leaflet-directive - so I began rolling my own... FWIW, this was as far as I got before I switched: https://github.com/tombatossals/angular-leaflet-directive/issues/320

[simison]

@denjello: somehow @Remigr got PruneCluster working with Angular-Leaflet; here. But he's a ninja...

Not sure though if he remembers what at PruneCluster's API would've made it easier for this to actually be useful for now. (note to self; always document findings while hacking away...)

[trygve-lie]

Not to derail this issue into a debate about the health of the project, but:

I hope we will get a new project using this plugin so we can improve it :-) I don't want to let it fade away

One way to secure the life of a project is to welcome multiple contributors. I am able to contribute in both my spare time and work time. But to be honest; that this module is written in TypeScript is holding me back from doing so. If this module was written in JavaScript I would contribute. I think this might be restraining other people which would like to contribute also.

Have you ever considered moving the source away from TypeScript?

[fungiboletus]

@trygve-lie I created a specific issue (#79) for discussing about this :-)

[bcalik]

Any progress on this? I would like to use Leaflet 1.0 on my project, but this plugin keeps me away.

@yellowiscool Maybe you should first make existing code compatible with 1.0 if its easy. Then you can rewrite the code later when you have time. Save the day :)

[simison]

How is this coming by? Beta 2 is out since this.

http://leafletjs.com/2015/10/14/leaflet-1.0-beta2-released.html

https://github.com/Leaflet/Leaflet/blob/master/CHANGELOG.md

[fungiboletus]

I have not progressed on this issue, but hopefully I should get some dedicated time in January.

Meanwhile, I will think about checking the example folder with the beta 2.

[fungiboletus]

The fractional zoom being fixed, leaflet 1.0.0 should work fine :)

[bcalik]

Thanks! Great news.

[denjello]

Congrats - and thanks for finding the time!

[pke]

I'll use this plugin in favour of the default marker cluster plugin. This here outperforms every other cluster plugin. Especially on mobile devices.

Thanks for making it compatible with 1.0

[c-martinez]

I'm looking into using PruneCluster, and wanted to know whether it is Leaflet 1.0 compatible. From this issue, I understand it is.

Is it worth mentioning that on the Readme and closing this issue?

[simison]

@c-martinez We're using PruneCluster at Trustroots.org (@Trustrotos/trustroots) without issues with Leaflet 1.2.0.

I'm not using popups or tooltips though — I've seen people reporting some issues around those but it's probably possible to go around those problems.