PruneCluster icon indicating copy to clipboard operation
PruneCluster copied to clipboard

PruneCluster.min.js.map missing from dist

Open denjello opened this issue 9 years ago • 5 comments

When I build with gulp and use PruneCluster.min.js, PruneCluster expects to find PruneCluster.min.js.map which does not exist in the /dist folder.

denjello avatar Jul 21 '15 18:07 denjello

You mean with Grunt? I haven't checked this since a long time, but it should be generated.

fungiboletus avatar Jul 21 '15 18:07 fungiboletus

I use bower to clone the prunecluster repo and then gulp to create my app from bunches of other repos... I am not building the prunecluster app, just using its distributed files, and in that distro the PruneCluster.min.js.map file is missing. Is that more clear?

denjello avatar Jul 21 '15 19:07 denjello

On the other hand...

the consensus is that JS in Bower packages should be built, but not minified. The simple reason being that most will minify them in their build step anyways, and having both bloats the package and complicates everything.

https://groups.google.com/d/msg/twitter-bower/P8TbooJPacs/dE5OdIGVEkQJ

simison avatar Oct 16 '15 16:10 simison

Ok, it makes sense. I will remove the minified JavaScript file from the Bower package.

fungiboletus avatar Oct 16 '15 16:10 fungiboletus

Cool. Remember to mark that as a breaking change.

simison avatar Oct 16 '15 16:10 simison