Proto2TypeScript icon indicating copy to clipboard operation
Proto2TypeScript copied to clipboard

Generated definitions are not usable in a browser

Open tamird opened this issue 7 years ago • 0 comments

Broken in 0c903645e26e6eb35b621f9c4aa8227aac28206b. That commit introduced hardcoded references to Buffer which is not defined in browsers, breaking Proto2TypeScript for non-Node environments.

From https://github.com/SINTEF-9012/Proto2TypeScript/pull/13#issuecomment-238301201:

But we should definitely fix that. The flag to enable the node-only definitions is a good idea. The tests could also be improved, they were develop when I was the single user of the project, and they are far from perfect.

@kalbasit @yellowiscool

tamird avatar Mar 21 '17 16:03 tamird