script.simkl icon indicating copy to clipboard operation
script.simkl copied to clipboard
verified publisher icon SIMKL

Make sure config value is used when showing bubble

Open 1nu opened this issue 10 months ago • 4 comments

Fixes #76 and #55

1nu avatar Feb 25 '25 22:02 1nu

Here is the solution guys, less work for you... and no offense but since this is an issue since 2019 I might as well do it myself.

  1. Go to the file Engine.py. Located inside data/org.xbmc.kodi/files/.kodi/addons/script.simkl/ressources/lib

  2. In the file, change this section:elif success and bool(get_setting("bubble")): self._show_bubble(self._item) break to elif success and get_setting("bubble") == 'true': self._show_bubble(self._item) break

Now the bool argument will correctly identify false in your user settings. The issue was the first implementation always considered result as true except empty arguments.

je19921 avatar Feb 27 '25 18:02 je19921

@ekleop will have some time to merge and recheck after March 3rd. The update to kodi repo should take about 2-8 weeks to be approved.

masyk avatar Feb 27 '25 18:02 masyk

/gemini review

masyk avatar Feb 28 '25 08:02 masyk

Did you get a chance to review this yet?

1nu avatar Mar 12 '25 12:03 1nu

Sooooo?

shawly avatar Sep 27 '25 15:09 shawly