Always showing bubble no matter the value in config

[weekendsource]

bool of nonempty string is always true so

https://github.com/SIMKL/script.simkl/blame/46c059b54df258ee42b80e455194f6fca5a83783/resources/lib/engine.py#L165

elif success and bool(get_setting("bubble")):

should be something like:

elif success and get_setting("bubble") == "true":

[ekleop]

I'll update it in next push, thanks

[je19921]

I'll update it in next push, thanks

This exact issue was flagged in 2019 and you had the exact same reply of i'll fix next update.. same response in 2020... how hard is it to fix this, it's been 6 years lol.

[je19921]

Here is the solution guys, less work for you... and no offense but since this is an issue since 2019 I might as well do it myself.

Go to the file Engine.py. Located inside data/org.xbmc.kodi/files/.kodi/addons/script.simkl/ressources/lib

In the file, change this section:

elif success and bool(get_setting("bubble")): self._show_bubble(self._item) break to elif success and get_setting("bubble") == 'true': self._show_bubble(self._item) break

Now the bool argument will correctly identify false in your user settings. The issue was the first implementation always considered result as true except empty arguments.