CITResewn icon indicating copy to clipboard operation
CITResewn copied to clipboard

CIT with damage values do not work

Open bbayu123 opened this issue 1 year ago • 2 comments

Version: 1.1.3+1.19.4 Fabric API Version: 0.83.0+1.19.4 Minecraft Version: 1.19.4 with Fabric Loader 0.14.21


Description: Any attempt to create a custom item (regardless of texture or model) given a damage value will not work. This behaviour is different from OptiFine, where the custom item will display properly.

Steps to reproduce:

  1. I have already created a minimal reproducible resource pack, which you can download: Test Pack.zip
  2. The resource pack only has 1 item, which is the item of focus. This item can be obtained using /give @p minecraft:wooden_hoe{Unbreakable:1b,Damage:28}
  3. The item is a grey cuboid, with white text on the side facing the player: a. The text is "CIT Failed" on vanilla, which is expected behaviour b. The text is "CIT Success" on OptiFine, which is also expected behaviour c. The text is "CIT Failed" on CITResewn, which is not expected behaviour
  4. The locations of assets are: a. Textures located at textures/test, with the atlases/blocks.json file configured correctly b. The base model located at model/test/test.json c. The "CIT Failed" model located at model/test/test_f.json, with its parent set to test/test d. The CIT Success" model located at optifine/cit/test/test_s.json, and the CIT properties at optifine/cit/test/test_s.properties. The model's parent is set to test/test e. All paths mentioned above are located in assets/minecraft

Other Information: This was known to be working as intended on 0.9.1+1.17.1.

bbayu123 avatar Jun 18 '23 04:06 bbayu123

I'll check it out when I'm able to, thanks for the test pack.

Your logs would've also been helpful because I can look at those from mobile.

SHsuperCM avatar Jul 09 '23 06:07 SHsuperCM

Hi, apologise for taking such a long time, but I have some client logs. These client logs are made using Minecraft 1.20.1 and CITResewn 1.1.3+1.20.1. The same problem still exists there. https://paste.ee/p/FYWbz

bbayu123 avatar Sep 02 '23 04:09 bbayu123