sftmumblebot icon indicating copy to clipboard operation
sftmumblebot copied to clipboard

Published 20 hours ago • verified publisher icon SFTtech

umurmur sends bot messages back leading to infinite bouces

Open m13253 opened this issue 10 years ago • 5 comments

My server is umurmur.

I type something in the IRC, the bot forwards to mumble, then forwards again back to IRC.

I think it is necessary to block out echos.

m13253 avatar Jul 31 '14 03:07 m13253

this can especially be a problem with multiple bots, indeed..

TheJJ avatar Jul 31 '14 10:07 TheJJ

why do you think that happens? does umurmur behave differently than murmurd does?

TheJJ avatar Jul 31 '14 11:07 TheJJ

why do you think that happens? does umurmur behave differently than murmurd does?

Perhaps umurmur sends the message back to the sender. So the bot is receiving what he said. And I have only one bot.

m13253 avatar Jul 31 '14 12:07 m13253

I have made some modification in my fork https://github.com/m13253/sftmumblebot fixing this problem and another problem that gtfo does not really terminates the program. I did this by adding a comment <!--sft--> before the message body. If the bot received a message beginning with <!--sft--> it will consider it an echo and simply ignore it.

m13253 avatar Aug 01 '14 06:08 m13253

IMHO this isn't the way to do it. The bot is aware of its username in mumble and IRC, so filtering for messages the bot sent itself should be trivial, even without manipulating the message. Please consider opening a pull request with your changes.

Hack on!

waaaaargh avatar Aug 01 '14 16:08 waaaaargh