openage icon indicating copy to clipboard operation
openage copied to clipboard

Pure fixed-point math functions

Open heinezen opened this issue 2 years ago • 10 comments

Required Skills: C++

Difficulty: Easy

We should add additional math operations to our fixed-point implementation, so that all calculations can be done purely deterministic.

The fpm library already has these operations and could be used as an inspiration.

Interesting for us:

  • [ ] sqrt
  • [x] min
  • [x] max
  • [x] abs
  • [x] hypot
  • [ ] atan2

Nice to have:

  • [ ] sin
  • [ ] cos
  • [ ] tan
  • [ ] pow
  • [ ] log

Further Reading

heinezen avatar Sep 17 '23 16:09 heinezen

@mingjuu You can :)

I'll assign you right now and if you have any questions, feel free to ask here or in chat.

heinezen avatar Oct 02 '23 08:10 heinezen

Hello, I am new to the project and wish I could join you. Can you assign this issue to me so that I can start from here?

AyiStar avatar Nov 25 '23 14:11 AyiStar

@AyiStar sure :)

heinezen avatar Nov 25 '23 15:11 heinezen

@heinezen Thank! I will touch you if I have any questions.

AyiStar avatar Nov 26 '23 13:11 AyiStar

Hello,

Is there anything left to do here that I can contribute to?

adamresemius avatar Dec 21 '23 07:12 adamresemius

@adamresemius Yes, the unticked boxes in the issue description is what's not implemented at the moment.

heinezen avatar Dec 22 '23 22:12 heinezen

I think I know how to implement the other functions in fpm. I have pow already on mine.

Zain-Balkhi avatar Feb 11 '24 04:02 Zain-Balkhi

Hey, I'm a beginner and could try my hand at implementing sqrt (and possibly the others after) if it isn't being worked on right now

firednerve avatar Aug 15 '24 20:08 firednerve

@firednerve You are welcome to go for it :)

heinezen avatar Aug 16 '24 21:08 heinezen

Thanks! I’ll ask if I have any questions.

firednerve avatar Aug 16 '24 21:08 firednerve