abrechnung icon indicating copy to clipboard operation
abrechnung copied to clipboard

Purchase position view seems to be broken

Open maciejewiczow opened this issue 1 year ago • 7 comments

2024-02-17_17h03_08 As can be seen in the animation above, the checkboxes do not work Idk what system info to give. There are no errors in the browser console, nor does the network tab look anything out of the ordinary. I am using a docker setup with a local database on a local server.

maciejewiczow avatar Feb 17 '24 19:02 maciejewiczow

After tinkering a bit a got it to update and actually save the positions from database, by first entering the amount/clicking one of the checkboxes, and then adding a new row with any amount other than 0 or with any of the checkboxes checked

maciejewiczow avatar Feb 21 '24 16:02 maciejewiczow

Interesting, thanks a lot for the report!

Currently the position table is a bit fiddly unfortunately, I agree. I'll have to revisit this and try to polish it a bit once I get around to it.

Which version are you running currently? Latest release?

mikonse avatar Feb 22 '24 09:02 mikonse

Can confirm the bug on our running ssn instance, also happens on mobile.

TheJJ avatar Feb 22 '24 10:02 TheJJ

Idk how to check the exact version being run, but I am using the latest-release tag from the docker repo. The images have been pulled around a week ago

maciejewiczow avatar Feb 22 '24 16:02 maciejewiczow

If added a fix in the latest release (v0.13.3) which fixes an issue that occurs when copying positions. This might have been the reason for the issue you were seeing. Can you check whether it still occurs?

mikonse avatar Mar 02 '24 11:03 mikonse

Sorry for late reply. Just pulled the latest docker images, sadly the issue persists

maciejewiczow avatar Mar 12 '24 20:03 maciejewiczow

The issue also still seems to be present on the demo instance as well

maciejewiczow avatar Mar 12 '24 20:03 maciejewiczow

After some investigation I can say the bug is still present on current master (d26106d4d97b101f5fbad03fe41e9f23015d4683).

It does not occur in the nx development mode (npx nx serve) but after building the webapp with npx nx build web application. I suspect a "compiler bug".

TheJJ avatar Aug 01 '24 21:08 TheJJ

as @mikonse suspected correctly, removing StrictMode lets the bug appear in development mode :)

TheJJ avatar Aug 03 '24 10:08 TheJJ

this has been fixed by #222

mikonse avatar Aug 16 '24 21:08 mikonse