Missing functions addition

[Luhrel]

I added some functions that were not implemented in CSFML. I also modified sfTexture_bind, with an sfTextureCoordinateType arg.

Modified: sfTexture_bind (Added sfTextureCoordinateType arg)

Added: sfTextureCoordinateType sfContext_isExtensionAvailable sfContext_getFunction sfRenderWindow_drawVertexBufferRange sfRenderTexture_drawVertexBufferRange sfTcpListener_close

[LaurentGomila]

There's a reason why some of these functions are not implemented. They are either for internal use (when it's the case, they are clearly documented as such) or not needed in C because of the API differences.

Of course, some functions may also simply be missing, most likely those that were added recently 😉

[Luhrel]

Yup I know and I didn't implemented those, did I ? Which funcs (in this PR) aren't needed in C ?

[LaurentGomila]

sfTcpListener_close is not needed since you just free (sfTcpListener_destroy) the instance when you're done with it.

sfTextureCoordinateType and where it's used, were initially meant for internal use only. I'm not sure if that changed since then.

[Luhrel]

sfTcpListener_close is not needed since you just free (sfTcpListener_destroy) the instance when you're done with it.

Ok, but should we add it anyway for the other SFML bindings (which are based on CSFML) ?

sfTextureCoordinateType and where it's used, were initially meant for internal use only. I'm not sure if that changed since then.

The doc just says :

[...] [sf::CoordinateType::Pixels] is used internally by the graphics classes of SFML, it makes the definition of texture coordinates more intuitive for the high-level API, users don't need to compute normalized values.

So it may be used.

[LaurentGomila]

Ok, but should we add it anyway for the other SFML bindings (which are based on CSFML) ?

Nop.

[silverweed]

@LaurentGomila how about the VertexBuffer functions? Would they be accepted if they were isolated in their own PR?

[LaurentGomila]

Is sf::VertexBuffer part of the latest version, or does it have to be released yet (I really don't remember 😁)?

[silverweed]

It's surely there in SFML 2.5 :D

[LaurentGomila]

Then OK, it should be in CSFML and SFML.Net too.

[silverweed]

Ok, cool :) @Luhrel, would you rather split your PR or let me reopen mine (#153)?

[Luhrel]

@silverweed There's no need to split/reopen. All the functions in this PR are for the 2.5.

@LaurentGomila Which name do you prefer sfRenderTexture_drawVertexBufferWithIndex or sfRenderTexture_drawVertexBufferRange ?

[LaurentGomila]

I'd say sfRenderTexture_drawVertexBufferRange.

[Luhrel]

@LaurentGomila Done. Maybe you can merge this now :wink:

[silverweed]

@LaurentGomila any news on this?

[eXpl0it3r]

Allowed myself to integrate the last commit in the relevant commits and rebase, as the pipeline was slightly outdated 😅

[eXpl0it3r]

Thanks a lot for these fixes and the patience. 🥳

Sorry again it took so long 😞