Snowfakery icon indicating copy to clipboard operation
Snowfakery copied to clipboard

Datasets are not closed

Open prescod opened this issue 4 years ago • 0 comments

This could cause problems relating to cleanup of tempfiles and file handles, especially on Windows.

Datasets need:

  1. Checking to avoid double-close
  2. An interpreter-wide weak-reference registry of Resource-holding PluginResults
  3. close() on interpreter cleanup

Perhaps a new PluginResult Subclass/ABC can implement 1 and 2.

prescod avatar Jun 05 '21 10:06 prescod